yasai's Introduction

YASAI: Yet Another Shogi library, for AI development

YASAI(野菜) is a Rust library for high-speed generation of legal moves and search for positions for Shogi. It is based on the implementation of apery_rust and uses shogi_core as the fundamental types and functions.

Examples

Perft

cargo run --release --example perft 5

yasai's People

Contributors

Stargazers

Watchers

yasai's Issues

打ち歩詰めでないものが打ち歩詰めと判定される

version: commit 9ea3831

図の局面で12歩は合法ですが、yasai では打ち歩詰めと判定されてしまいます。

金/馬/飛/龍がまっすぐ引いて歩を取る手は(たとえ pin されていても)常に可能なので、歩を打った筋については pin 判定の対象外とする処理が必要だと思います。

また別件なのですが、こちらのコードは玉の移動先から既に single が除かれているのにさらに single を XOR しているため、結局玉で歩を取る手を二重に判定してしまっているようです:

yasai/src/movegen.rs

Lines 364 to 374 in 9ea3831

 // 玉が逃げられる 

 if let Some(king) = self.king_position(c.flip()) { 

 let single = Bitboard::single(sq); 

 let escape = 

 ATTACK_TABLE.ou.attack(king, c.flip()) & !self.player_bitboard(c.flip()) & !single; 

 let occupied = self.occupied_bitboard() | single; 

 for to in escape ^ single { 

 if self.attackers_to(c, to, &occupied).is_empty() { 

 return false; 

 } 

 }

UB in MASKED_BBS's definition

I'm not 100% sure that this is worth an issue, but this line causes undefined behavior. (Bitboard does not allow the 1 << 63-bit to be set)

https://github.com/sugyan/yasai/blob/0.4.0/src/bitboard/core.rs#L75

I'm planning to display warnings against such uses in future shogi_core.

`ZobristTable::hands` is too small

MAX_HAND_NUM is 18. For a position where someone has all 18 pawns in hand, this line probably causes out-of-bounds accesses.

yasai/src/zobrist.rs

Line 52 in a7011ec

hands: [[[Key; ZobristTable::MAX_HAND_NUM]; 8]; Color::NUM],

Performance improvement

#5
Use SIMD (#1)
...?

Recommend Projects

sugyan / yasai Goto Github PK

yasai's Introduction

YASAI: Yet Another Shogi library, for AI development

Examples

Perft

yasai's People

Contributors

Stargazers

Watchers

Forkers

yasai's Issues

打ち歩詰めでないものが打ち歩詰めと判定される

UB in MASKED_BBS's definition

`ZobristTable::hands` is too small

Performance improvement

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// 玉が逃げられる
	if let Some(king) = self.king_position(c.flip()) {
	let single = Bitboard::single(sq);
	let escape =
	ATTACK_TABLE.ou.attack(king, c.flip()) & !self.player_bitboard(c.flip()) & !single;
	let occupied = self.occupied_bitboard() \| single;
	for to in escape ^ single {
	if self.attackers_to(c, to, &occupied).is_empty() {
	return false;
	}
	}