Git Product home page Git Product logo

pcb's People

Contributors

joepater avatar maxobrien avatar mxrxk avatar saltyboi2995 avatar t-bre avatar

Stargazers

 avatar  avatar  avatar

pcb's Issues

bug(bspd): bad footprint for transistor

Description

The footprint for the transistor which is used in the following circuit is wrong:

Screenshot 2023-03-24 at 21 03 34

The footprint is BCE, but most transistors we have (BC557, 2N3906) are CBE.

Expected Behaviour

Footprint changed to CBE.

bug(vcu): R2D and VC LED outputs swapped

Description

The VCU has the R2D and VC LED outputs swapped.

Screenshot 2023-06-02 at 23 19 39

Additional Notes

Small schematic error, easily fixed in a future revision. This has been patched in software for now, remember that it will need to be changed if this is fixed on the PCB.

feat(vcu): label power input polarity on front silkscreen

Description

It would be useful to show the polarity of the power input connection on the front silkscreen. Currently it is only labelled on the back.

Additional Notes

This definitely used to be on older designs, but must have accidentally been removed at some point.

bug(vcu): analogue inputs not buffered

Description

Analogue inputs from the APPS need to be buffered as the current resistor divider design affects the transfer function of the sensor.

Expected Behaviour

Unity gain op-amp buffers added to analogue input channels.

bug(latching): signals latch to wrong state

Description

Latching behaviour is the opposite of what we want, currently the output latches high when leaving the fault state and entering the "ok" state.

Expected Behaviour

Output latches low when leaving "ok" state and entering fault state.

Additional Notes

The inputs from the BMS and IMD need to be inverted and Q' of the latches used as the output. Q = 1 should represent a fault state and Q = 0 should represent an "ok" state.

feat(vcu): update to STM32-F746ZG board

Description

Update schematic for STM32-F746ZG board.

Requirements

  • New schematic for STM32-F746ZG connectors.
  • Remove third CAN transceiver.
  • Update connections from MCU to rest of board.

chore: update to KiCad 7

Description

Opening projects created in KiCad 6 with KiCad 7 causes a change to the project file which may be accidentally committed if the project is opened for reference when working on something else. To avoid merge conflicts caused by this, we should probably just open everything in KiCad 7 once and commit the changes.

feat(vcu): add EEPROM memory

Description

Add NVM for use by the VCU microcontroller for parameter configuration.

Requirements

  • Spec new EEPROM.
  • Add to schematic.

bug(hvs): non-standard resistor values

Description

The resistor values used to divide down the HV are very non-standard and not generally stocked at the university. They should ideally be replaced with values which are more common.

Screenshot 2023-06-08 at 16 46 47

feat(bspd): add indicator LEDs

Description

Add LEDs to indicate key states in the BSPD:

  • SCS implausible (red, on during fault).
  • Brake and throttle pressed (red, on during fault).
  • Shutdown output state (green, on if shutdown circuit closed).

Additional Notes

SMD LEDs on the PCB and one external LED on the BSPD box (via connector).

bug(vcu): Molex connectors should be reversed

Description

Clips on Molex connectors are currently facing towards the inside of the board. This makes it harder to remove them.

Screenshot 2023-02-07 at 16 37 55

Expected Behaviour

Clips facing towards outside of board.

bug(latching): IMD input not pulled down

Description

IMD input is not pulled down which is potentially undefined behaviour if the connection is broken and the input is floating.

Expected Behaviour

IMD input pulled down.

bug(vcu): 5V regulator tab is not ground

Description

5V regulator tab is the regulator output and not ground. This causes a short to the large exposed copper pad. The net of the pad should be changed to 5V and a new (small) 5V plane created.

feat(latching): add labels

Description

PCB is currently un-labelled, would be nice to add:

  • Connector names on the top of the board.
  • Pin names on the bottom of the board.
  • The project name and version number.
  • SUFST stag logo (if space).

bug(latching): latching mechanic not working

Description

The design using the D-type flip flops U1 seems to not be working. The potential culprits could be the power on state (POR) or the method in which U1 is wired.

A redesign is required.

Steps To Reproduce

  1. Connect power into the circuit using 12V supply
  2. Connect the IMD_Ok signal into the board (J2 pin 2) and connect to 10V supply
  3. Connect the IMD_OK_LATCHED signal to an oscilloscope (J3 pin 2)
  4. Power on 12V and 10V simultaneously. You will notice that the latching will latch into the fault state (J3 pin 2 LOW). This issue persists even if the IMD_Ok signal is connected to the 12V supply to have a truly simultaneous connection in.
  5. Power on 10V slightly earlier than 12V. You will notice that the latching will now latch in the no-fault state (J3 pin 2 HIGH). However when IMD_Ok signal is sent to the fault state, the circuit remains latched in the no-fault state.

Environment

B16 tools and equipment

Expected Behaviour

When turned on simultaneously, the circuit should boot up in a no-fault state given that no faults are detected. If a fault is detected, the circuit must latch in the fault state and remain latched even if the IMD_Ok state changes to the no fault state. Power cycling the circuit should remove the error given that the signal is in a no-fault state.

feat: import existing designs

Description

Import existing designs into this repo.

Requirements

  • VCU
  • TSAL
  • HV sense
  • BSPD
  • Discharge
  • Latching
  • Precharge.

feat(vcu): replace DRS driver with timer pin output

Description

DRS servo can be driven directly from a timer pin on the MCU, instead of with an extra driver chip.

Requirements

  • Remove old driver chip.
  • Add DRS output pin to MCU.
  • Level shift DRS output.
  • Add DRS to connector.

Additional Notes

The servo is 5V, so the 3.3V MCU output will need to be level shifted.

feat(vcu): update DRS servo hardware to 12V

Description

Change DRS servo control system to operate at 12V. Potentially add a current measurement mechanism for intelligent servo control. The 5V regulator can be removed, which will fix #49.

bug(tsal): Molex connectors should be reversed

Description

Clips on Molex connectors are currently facing towards the inside of the board. This makes it harder to remove them.

Screenshot 2023-02-07 at 16 39 44

Expected Behaviour

Clips facing towards outside of board.

bug(tsal): fp-lib-table contains user-specific paths

Description

fp-lib-table for TSAL contains:

(fp_lib_table
  (lib (name "footprints")(type "KiCad")(uri "/home/joe/pro/sufst/precharge/hardware/precharge/footprints.pretty")(options "")(descr ""))
)

This should be a path relative to the project, instead of an absolute path specific to one user.

Not sure if this breaks the PCB in some way?

Steps To Reproduce

  1. Look at contents of tsal/fp-lib-table.
  2. Single entry in table with path specific to one user.

Expected Behaviour

No absolute paths in table.

bug(vcu): EEPROM IC orientation not clear on silkscreen

Description

When soldering the board, it is hard to tell what the correct orientation of the EEPROM IC is. There is a small dot, but it's not immediately obvious because it really is tiny. Might be good to add a larger dot/circle below pin 1. The reference designator for the IC is also on the opposite side to the dot, which could be incorrectly interpreted as the side of pin 1 if the dot isn't seen.

Screenshot 2023-04-16 at 23 24 00

bug(hvs): missing / modified symbols

Description

Some symbols were missing after migration from the old separate PCB repos to this new monorepo. The schematic / PCB are fine, but these should be sorted eventually.

Additional Notes

Causes ERC errors below:

Screenshot 2023-04-02 at 22 21 28

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.