subzerocloud / apgdiff Goto Github PK

This is really a minor issue, but

$ java -jar ./apgdiff-2.6.6-subzero.jar --version
Version: 2.6.2-subzero

I just noticed but it was the same in an earlier release:

$ java -jar ./apgdiff-2.6.4-subzero.jar --version
Version: 2.6.2-subzero

fordfrog/apgdiff does not support Postgres 10 sequences. Running apgdiff where there are Postgres 10 sequences will produce an exception similar to the following: cz.startnet.utils.pgdiff.parsers.ParserException: Cannot parse string: CREATE SEQUENCE. This is issue #225 on fordfrog/apgdiff and pull request #228 has a fix, but is waiting to be merged.

It would be useful to me if the subzero apgdiff fork had that fix.

(Thanks for all your help!)

Here it is for the table
https://github.com/fordfrog/apgdiff/blob/caaaed9d6189f4ee6319c119137c2c701f76ecd8/src/main/java/cz/startnet/utils/pgdiff/PgDiffTables.java#L545-L549

the view needs to have the same behaviour

When following the API Core and creating a single migration from all the changes there I got these SEQUENCE errors:

• Getting GRANT TABLE instead of GRANT SEQUENCE:

-- Incorrect
REVOKE ALL ON TABLE client_id_seq FROM webuser;
GRANT USAGE ON TABLE client_id_seq TO webuser;
-- Correct
REVOKE ALL ON SEQUENCE client_id_seq FROM webuser;
GRANT USAGE ON SEQUENCE client_id_seq TO webuser;

See the manual change necessary to fix the migration here.

• Getting CREATE TABLE's with inline DEFAULT nextval, before CREATE SEQUENCE.

CREATE TABLE client (
  id integer DEFAULT nextval('client_id_seq'::regclass) NOT NULL
  ..
ERROR:  relation "data.clients_id_seq" does not exist

The reordering needed to fix this issue is not that simple, one needs to move the CREATE SEQUENCE before the table declarations and the ALTER SEQUENCE OWNED BY must be moved after, manual fix in the migration here.

Though with apgdiff the reordering of statements sometimes needs to happen, this last reorder could be avoided altogether by changing the apgdiff DEFAULT nextval inline style to an explicit ALTER like the way pg_dump does:

ALTER TABLE ONLY client ALTER COLUMN id SET DEFAULT nextval('client_id_seq'::regclass);

The change in the migration with this style is like this.