sturivny / atm Goto Github PK

Bug #222 in the method test_wrong_two_times_last_right:

def test_wrong_two_times_last_right(self):
    """ two times wrong ,last right 
        1.enter incorrect pin(111)
        2.enter incorrect pin(111)
        3.enter correct pin (777)"""
    try: 
        self.atm.enter_pin(111)
    except IncorrectPin:
        try: 
            self.atm.enter_pin(111)
        except IncorrectPin:
            try:
                self.atm.enter_pin(777) 
            finally:
                self.assertEqual(10000,self.atm.check_balance())

My propose to fix it:

__attempts in the file atm.py should be
__attempts = 3

when I try to get_money(-1) and after it check_balance program works incorrect.

from atm import Atm
terminal = Atm()
terminal.enter_pin(777)
True
terminal.get_money(-1)
-1
terminal.check_balance()
10001

I propose to edit code such:
in the atm.py add this code
def get_money(self, money):
"""Method to get some money for sweets from the ATM"""
if self.__client_can_get_money:
if money < 0:
raise MinusGetMoney("Number can't be minus!!!")

        if money <= self.__atm_balance:
            self.__atm_balance = self.__atm_balance - money
            return money
        else:
            raise AtmBalance("Atm balance is no enough!!!")
    raise EnterPin("Enter pin first!!!")

and in atm_exceptions.py add this code:

class MinusGetMoney(Exception):
pass
after this operations the resuls will be correct

from atm import Atm
terminal = Atm()
terminal.enter_pin(777)
True
terminal.get_money(-1)
Traceback (most recent call last):
File "", line 1, in
File "atm.py", line 35, in get_money
raise MinusGetMoney("Number can't be minus!!!")
atm_exceptions.MinusGetMoney: Number can't be minus!!!