strongdm / charts Goto Github PK

The StrongDM documentation recommends running Gateway & Relay Nodes in pairs within the same environment: https://www.strongdm.com/docs/admin/nodes/

I'd like for the Helm chart to have multiple replicas configured and have the deployment spec filled out with proper health checks & tolerances so that a rolling deployment always keeps 1 replica in a healthy state.

Hello StrongDM team,

I'd be useful when using your chart as a sub-chart to be able to override the name of resources instead of using directly {{ .Release.Name }} for naming the resources like most community charts support.

Also, why are many values set under global? This is something you normally use when you want to share values with subcharts however here they are consumed locally by the charts themselves :
https://helm.sh/docs/chart_template_guide/subcharts_and_globals/

A last thing I noted while using this chart, it'd be great if we had the possibility to pass a user defined secret for the token.

Given a values file like:

global:
  ...
  extraEnvironmentVars:
    - name: ABC_EFG
      value: "hello"

The template renders:

        env:        
        - name: "%!S(INT=0)"
          value: "map[name:ABC_EFG value:hello]"

Making the following change appears to correct:

remove:
        {{- include "sdm.extraEnvironmentVars" .Values.global | indent 8 }}
add:
        {{- range .Values.global.extraEnvironmentVars }}
        - name: {{ .name }}
          value: {{ .value | quote }}
        {{- end }}

Opened on @wcraigjones behalf