Git Product home page Git Product logo

Comments (7)

maccman avatar maccman commented on August 29, 2024

3 digit Amex CVCs are valid. Amex CVCs can be 3 or 4 digits.

from paymentkit.

mrmonopoly237 avatar mrmonopoly237 commented on August 29, 2024

Totally didn't know that, thank you.

However, it appears that the delegate call back on PKView only happens after the third digit is entered. If the user enters a 4th digit there is no call-back or indication that this has happened.

from paymentkit.

sebbean avatar sebbean commented on August 29, 2024

3 digit amex's are valid - but stopping at the 3rd digit makes 4 digit amex' cvc's impossible to type in.

the keyboard is dismissed at the 3rd digit even if it's an amex (and could possibly have a 4th digit)

This is definitely still an open issue

from paymentkit.

sebbean avatar sebbean commented on August 29, 2024

Also, are you sure AmEx currently issues cards with 3 digit codes?

Light googling returned:

http://www.cvvnumber.com/cvv.html

American Express® cardholders:
Look for the 4-digit code printed on the front of your card just above and to the right of your main credit card number. This 4-digit code is your Card Identification Number (CID). The CID is the four-digit code printed just above the Account Number.

from paymentkit.

maccman avatar maccman commented on August 29, 2024

However, it appears that the delegate call back on PKView only happens after the third digit is entered. If the user enters a 4th digit there is no call-back or indication that this has happened.

@michaelvillar ?

from paymentkit.

sebbean avatar sebbean commented on August 29, 2024

this seems to fix it (in PKView.m ~line 266)

Sorry - new to pull-requests n what not, meant to do it that way.

- (BOOL)isValid
{    
    return [self.cardNumber isValid] && [self.cardExpiry isValid] &&
           [self.cardCVC isValidWithType:[[PKCardNumber cardNumberWithString:cardNumberField.text] cardType]];
}

from paymentkit.

michaelvillar avatar michaelvillar commented on August 29, 2024

@sebbean AMEX have 3 digits code as well.

Here is the fix d6f9f94

from paymentkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.