Git Product home page Git Product logo

Comments (9)

2ndmouse avatar 2ndmouse commented on July 25, 2024

+1 for this. I went into this problem yesterday.

from paymentkit.

billburgess avatar billburgess commented on July 25, 2024

The frame you set PTKView to is completely ignored (other than x and y placement). All views and subviews are hardcoded. I kinda expected more from a Stripe library. I realize it is free, but this helper view is almost unusable in the current state.

I'd love to hear from one of the Stripe devs if a rewrite and pull request would be accepted to rework the view to use auto layout, or at the very least, some better layouts given the frame passed in.

from paymentkit.

justjoeyuk avatar justjoeyuk commented on July 25, 2024

This is ridiculous. +1

from paymentkit.

sorin avatar sorin commented on July 25, 2024

+1 The reason I used Stripe in the first place is that it's super easy to integrate. This is not super easy to integrate. Please make this widget flexible size and add the zip code too.

from paymentkit.

yforjindam avatar yforjindam commented on July 25, 2024

+1 Easy fix?

from paymentkit.

N4tr0n avatar N4tr0n commented on July 25, 2024

+1 Please fix or at least address the comment made by @billburgess

from paymentkit.

danieladias avatar danieladias commented on July 25, 2024

For anyone interested we ended up using this fork: https://github.com/lmcd/LMPaymentKit which is working full width in @3x (see its Readme file).

cc @madhikarma

from paymentkit.

john-langley avatar john-langley commented on July 25, 2024

+1 ... issue raised by @billburgess is brutal and shouldn't be that difficult to fix.

from paymentkit.

jflinter avatar jflinter commented on July 25, 2024

Hey all,

First, I'm very sorry for our delay in addressing this issue. This repository has had a lot of outstanding issues for some time now, and we've recently completed a large refactor that should address most of them.

This code has moved to https://github.com/stripe/stripe-ios, which now has a class called STPPaymentCardTextField that has similar behavior to PTKView. It's designed to scale to different resolutions much more flexibly, so I'd encourage you to migrate (it should take just a few minutes, and we've written a brief guide at https://github.com/stripe/paymentkit#migration). Of course, if that doesn't work for you, or you have any trouble migrating, reply here and I'll be happy to help.

Thanks for your patience, and I hope STPPaymentCardTextField is a good fit for your needs.

from paymentkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.