strateus / tripletchain Goto Github PK

I think, there is some issue in gradient calculation part:

calculating n-p, p-a and a-n elementwise differences
n_p_diff = n-p
p_a_diff = p-a
a_n_diff = a-n
calculating Loss derivatives over a, n, p
dLda = n_p_diff * 2 / N
dLdp = p_a_diff * 2 / N
dLdn = a_n_diff * 2 / N

If we calculate loss gradient with respect to a,p,n then these statements should be:

calculating n-p, p-a and a-n elementwise differences
n_p_diff = n-p
p_a_diff = -a
a_n_diff = a
calculating Loss derivatives over a, n, p
dLda = n_p_diff * 2 / N
dLdp = p_a_diff * 2 / N
dLdn = a_n_diff * 2 / N

Please correct me, if I am wrong...