Git Product home page Git Product logo

Comments (4)

Olf0 avatar Olf0 commented on August 23, 2024

A better idea for reducing the width of the "< >" button (than reducing its font size or margins) is to use a smaller space between the two brackets, e.g. the Unicode code point U+200A "Hair space" (i.e. < >), U+2009 "Thin space" (i.e. < >) or U+2006 "Six-per-EM space". Actually the U+200A "Hair space" looks best and most reasonable to me.

from harbour-storeman.

Olf0 avatar Olf0 commented on August 23, 2024

Oh, I missed to reason why a strikeout button is needed, IMO:
Strikeout is quite useful when correcting comments which already have follow-up comments, in order not to disrupt the reading flow for others (i.e. not to render the follow-up comments idiotic).

from harbour-storeman.

mentaljam avatar mentaljam commented on August 23, 2024

Hi,
I also think that all buttons should have the same width but I don't know how to show for example the pre tag. About the code tag - there is no space between brackets at all.

https://github.com/mentaljam/harbour-storeman/blob/dd762bffd51d590419a1abd1ff5aecfe2b4834cb/harbour-storeman/qml/components/CommentField.qml#L157

Also note that the buttons widget is flickable and could be swiped to the left/right. So some buttons could be "hidden" and a hint to swipe could be showed to the user on the first use.

from harbour-storeman.

Olf0 avatar Olf0 commented on August 23, 2024

Thanks for your prompt reply and the pointer to the code. Well, while reading your reply, I thought "Oh", and "Oh, again", as I did neither expect setting the button width to a fixed size and having its content "fit to size" being impossible or being unable to set the font size.
Well, before HTML5 the font tag supported a size attribute, e.g. <font face="monospace" size=2>foo</font>, maybe it is worth a try.
Otherwise the only option I can currently see to shrink the oversized "< >" and "pre" button content is to use a different font than monospace. On first thought, the regular font with "< >" separated by aforementioned hair space (plus maybe set in bold) and "pre" set in bold might fit well.

But as the whole button line is flickable, a "strikeout" button (preferably inserted between the "underline" and "quote" buttons) seems to be feasible (at least under GUI aspects), right?

from harbour-storeman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.