stokingerl / ng2-sticky-nav Goto Github PK

Pretty sure the removal of long-deprecated Renderer causes this library to break.
https://angular.io/guide/migration-renderer
Apparently moving to Renderer2 is easy.
Package seems to be missing proper peer dependencies, for what it's worth.

ERROR in node_modules/ng2-sticky-nav/dist/src/sticky-nav.directive.d.ts:1:10 - error TS2724: Module '"<...>/node_modules/@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?

1 import { Renderer, ElementRef, OnInit, OnDestroy } from '@angular/core';
           ~~~~~~~~

  node_modules/@angular/core/core.d.ts:5692:31
    5692 export declare abstract class Renderer2 {
                                       ~~~~~~~~~
    'Renderer2' is declared here.

ERROR in ./node_modules/ng2-sticky-nav/index.ts
Module build failed: Error: C:..\node_modules\ng2-sticky-nav\index.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).
at AngularCompilerPlugin.getCompiledFile (C:\Aluminyze\Source\aluminyze-static\Aluminyze.Static\Scripts\azWebApp\node_modules@ngtools\webpack\src\angular_compiler_plugin.js:677:23)
at plugin.done.then (C:\Aluminyze\Source\aluminyze-static\Aluminyze.Static\Scripts\azWebApp\node_modules@ngtools\webpack\src\loader.js:467:39)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
ERROR in ./node_modules/ng2-sticky-nav/src/sticky-nav.directive.ts

First fo all thank you for my help. I have find a issue in ng2-sticky-nav when i rotate my mobile nav sticky before reached before position.

I want to create a sticky nav in angular 6 but unfortunatelly does not work

Here is is error I am getting ERROR in node_modules/ng2-sticky-nav/src/sticky-nav.directive.ts(21,20): error TS2339: Property 'fromEvent' does not exist on type 'typeof Observable'.

can you please update the package for angular 6 users?

@stokingerl Can you publish the latest version? Or give me permissions to publish (same name on npm - willyboy)

Hi ,
I am using this feature in one of my project.It works well in IE but in chrome and firefox on scroll the nav shifts from right to left.

When treeshaking is enabled, adding this module increases the filesize of the final package from 200kb to 750kb. It is a rather drastic increase.

When installing this package I get the following warnings:
1. npm WARN deprecated [email protected]: this library is no longer supported
2. npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in
certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
3. npm WARN deprecated [email protected]: request has been deprecated, see request/request#3142

They all seem to stem from the dependency on [email protected]. Is there a way to upgrade the package so that it is no longer dependent on request that is now in maintenance mode.

I got following warning when i build production mode :

Warning: ......... depends on 'ng2-sticky-nav'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies