stevenlundy / giphy-for-github Goto Github PK

Thanks for the project it's been useful for adding relevant gifs to PR approvals.

I've done some changes to make it work in firefox, but before posting my own fork I realized there's no license within the codebase.

Would you consider adding a license?

via GIPHY

I'd love to be able to use this on my enterprise instance could we configure the url(s) this works on?

Even if users updated to 1.0.2 they have invalid ratings unless they go to the settings and change it.

One second isn't always long enough for the page to load.

Maybe try listening for AJAX request
http://stackoverflow.com/questions/3596583/javascript-detect-an-ajax-event

When navigating with back and forward buttons, multiple GIF buttons can be added.

Press "Review changes" and try to press "GIF". Nothing happens. Console displays

main.js:98 Uncaught TypeError: Cannot read property 'querySelector' of null
    at HTMLButtonElement.handleGIFButtonClick (main.js:98)

GitHub is a single page application. When you move from the pull request page to a specific pull request, the page does not reload so the extension does not process the DOM to add the GIF button to the toolbars.

Probably will need to add a setInterval that checks location.href to see if it has changed and if it has, run the script again.

The GIF button tries to submit the comment when it is used on inline comments.

All is not being accepted as a rating format.

Invalid rating format. Use one of "y","g", "pg", "pg-13", "r", "unrated", "nsfw", ""
Ratings should be updated to match the api