sterc / mapstv Goto Github PK

After the Update to 2.5.6 ....any idea
[2017-04-01 11:19:39] (ERROR @ /www/htdocs/path-to-website/modx/core/components/mapstv/elements/tv/input/mapstv.class.php : 65) PHP warning: Declaration of MapsTvInputRender::process($value, $params = Array) should be compatible with modTemplateVarRender::process($value, array $params = Array)

Hi!

I'm sometimes getting a few of those errors in my modx error log… Looks like the mapstv class isn't handling empty TV values correctly?

[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 48) PHP warning: Illegal string offset 'street'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 49) PHP warning: Illegal string offset 'housenumber'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 50) PHP warning: Illegal string offset 'zipcode'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 51) PHP warning: Illegal string offset 'city'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 52) PHP warning: Illegal string offset 'state'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 53) PHP warning: Illegal string offset 'country'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 54) PHP warning: Illegal string offset 'latitude'
[2016-01-03 12:51:52] (ERROR @ /core/components/mapstv/elements/tv/input/mapstv.class.php : 55) PHP warning: Illegal string offset 'longitude'

http://maps.google.com/maps/api/js?sensor=false
needs language param

I've noticed this warning today:

Google Maps API warning: NoApiKeys
https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys

I don't find a system setting or a plugin property to store the key.

As far as I know API keys are still not enforced, but I guess it would be a good idea to have an option to include them in the API call.

Cheers,

Patrick

The tv doesn't appear to function inside a MIGX template variable.

Form tabs
[ { "caption": "Office", "fields": [{ "field": "title", "caption": "Title" }, { "field": "tel", "caption": "Telephone" }, { "field": "office", "caption": "Office", "inputTV": "contact-office" } ] } ]

Grid Columns
[ { "header": "Title", "width": "160", "sortable": "true", "dataIndex": "title" } ]

"contact-office" TV

Inside MIGX item creator

Other comments
I notice when I close the MIGX window and then re open in the text input boxes are broken, it looks like the TV breaks something in the MIGX's JavaScript.

If no location is set the JSONtoChunk Snippet crashed while trying to convert JSON to array.
Possible fix can be a guardian. Tested modification:

if (!$input) return "null";

$array = $modx->fromJSON($input);
if (count($array) > 0) {
    $chunk = $modx->getObject('modChunk', array('name' => $options));
    if ($chunk) {
        $output = $chunk->process($array);
    }
}
return $output;

When installed, to modify a resource I can not access template variables

Title change for "undefined"

Modx: modx-2.3.3
PHP: 5.2

Ability to lookup GEO data with less data. More like a autosuggest lookup

https://gist.github.com/fosil/9a71296ad7d1af428ced/

Feature request to be able to set default longtitude and latitude to ensure an initial map is rendered.

Adding a tv (ourLocation) and inserting it via the tv call [[*ourLocation:JSONtoChunk=mapRender]] only displays the placeholders. No map is displayed.

mapRender contains:

Housenumber : [[+housenumber]]
Zipcode : [[+zipcode]]
City : [[+city]]
State : [[+state]]
Country : [[+country]]
Latitude : [[+latitude]]
Longitude : [[+longitude]]

There are no errors in the browser console.
There was one modx warning #23 which I've corrected - see #24

OSX
MODX 2.6.1
Chrome 63.0.3239.132

In the documentation this is the template call:
[[*tvValue:JSONtoChunk=ChunkName]]

It should be:

[[*tvValue:JSONtoChunk=`ChunkName`]]

In the console, the browser chrome error appears:
Uncaught TypeError: Can not read property 'lat' of null

Coordinates are empty and therefore a bug. Generating the address is not working. Button incorrectly looks. I'm not good in ExtJs and could not fix it

Thanks in advance!

Is there a way to possibly have a 1 click - generate all button?

We bulk import resources using this TV to create a directory with lat/lon, however using this we have to go through each resource 1 by 1 to click the button to generate lat/lon. Is there any plugin or master button to loop through resources and generate each resources lat/lon?

Thanks!

In some cases the preset minGeoAccuracy: 'ROOFTOP' (in Ext.ux.GMapPanel3.js) does not generate a latitude / longitude. Setting the value to for instance 'APPROXIMATE' solves some of these issues.
Therefore it would be nice to add a system setting or a TV property (so you can override on a per TV base) for the minGeoAccuracy.

Another error in the console after loading a manager page including gmapstv:

This happens in 2.2.16 as well as 2.5.0

mapstv.js?v=250pl:234 Uncaught TypeError: Cannot read property 'getViewSize' of null

// assets/components/mapstv/js/mgr/mapstv.js?v=250pl line 234: var width = Ext.get('modx-resource-settings').getViewSize().width - vtabswidth - padding;
This part of the function should be triggered 'afterrender' at which point 'modx-resource-settings' should already be present.

I don't get it.

Any ideas?

hello,
i got an error if i move the marker and reload the modx resource. do you have an idea to fix it?
maybe there is an error on this line:

Ext.getCmp('mapstv'+config.tvId+'-longitude').setValue(LatLng[Object.keys(LatLng)[1]]);

video for reproducing the bug: http://quick.as/pzrdtbaa5

thanks a lot
jens

Maps TV v 1.0.1. I've entered addres, clicked on button "generate..." and got latititude and longtitude values. Then I dragged marker into another position.

Latititude after that contains string "function() {return a;}" and longtitude contains string "function() {return b;}"

What have I done wrong way?

Please change the following in "mapstv.js" to support http(s):
document.write('<script src="//maps.google.com/maps/api/js"><\/script>');