stephengregory / taskerjavascripthelpers Goto Github PK

The JavaScript action times out, but there are no notifications indicating what has happened.

Recent refactoring is the suspected culprit.

It was known to be working in aa19058.

When a machine becomes available, the person that last used it may not have removed their laundry yet. Since there's no indication of whether a machine has been emptied, add a configurable number of minutes, after a machine used by someone else is reported as available, to notify me that it is available.

As expected, the format of the source page has changed, so parsing is now failing.

https://imagecomics.com/comics/series/the-walking-dead

Therefore we cannot extract the next issue details.

Sometimes I forget what variables I set in a task and have to refer back to the JavaScript to see what I named them. It'd be convenient if a variable was exporting containing that information.

For example, for a helper that does this:

Tasker.setLocalVariable('foo', [1,2,3]);
Tasker.setLocalVariable('bar', "this is wonderful");

Have it internally set jsdebug to:

JS set the following local variables:
Arrays: foo
Strings: bar

So in the Tasker task:

• JavaScript action
  • calls above helper
• Flash action
  • flashes %jsdebug

Noticed that the Pokemon tutorial appears to be broken in a couple of places

1. Sandbox Tutorial

After finishing, running command
node sandbox/sandbox.tasker.pokemonInfoHelper.js'
gives error "FIle you are testing does not exist: [...]/TaskerJavaScriptHelpers-master/src/pokemonInfoHelper.js"

Found the issue - the Sandbox file doesn't include lines to rename the file.
Should require 'path' at the start and replace the final line with

const currentScriptFilename = path.basename(__filename);
const scriptFilenameToTest = currentScriptFilename.replace('sandbox.', '');
taskerSandbox(scriptFilenameToTest, taskerLocalVariables);

3. Exporting Script Tutorial

This step just doesn't work. Running npm run taskerfy gives error message:

[...]/TaskerJavaScriptHelpers-master/src/tasker.pokemonInfoHelper.js
  25:35  error    'pokemon_json' is not defined                  no-undef
  26:34  error    'use_shiny_image' is not defined               no-undef
  64:58  warning  Newline required at end of file but not found  eol-last

Can't find what's causing it to not import the local variables, but I'm basically a novice so it might be something obvious. Tried to check how the example one for Sparkle Laundry does it but can't figure it out.

The page used to find the next issue information no longer exist.