Git Product home page Git Product logo

Comments (6)

jszobody avatar jszobody commented on June 5, 2024

The auto-injected banner is dark by default. I just added a bottom-border so that it looks a bit better above the rest of the UI:

CleanShot 2022-04-29 at 08 36 18@2x

That what you had in mind?

from filament-impersonate.

Saifallak avatar Saifallak commented on June 5, 2024

@jszobody nope, i guess he means the banner toggles light/dark with filament

from filament-impersonate.

jszobody avatar jszobody commented on June 5, 2024

@Saifallak I designed the banner to be "dark" all the time by default. Even when filament is in light mode, the impersonation banner at the top is dark. So what's there to toggle? I can't imagine you'd want the banner to be light when filament goes dark??

from filament-impersonate.

Saifallak avatar Saifallak commented on June 5, 2024

nope i meant when :

  • filment is dark the banner is dark

image

  • and when filment is light, the banner is light.
    image

from filament-impersonate.

jszobody avatar jszobody commented on June 5, 2024

Happy to review a PR if someone wants to take a stab, going to close this for now.

from filament-impersonate.

jszobody avatar jszobody commented on June 5, 2024

This is now done in 2.13

from filament-impersonate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.