Formatting of Action in a group doesn't match other Actions about filament-impersonate HOT 6 OPEN

Just adding to this, based on Filament's defaults, I think that this possibly suits as the default values and then in the docs might be worth adding the different styles (eg button-only view, larger icon etc.)

Impersonate::make()
    ->link()
    ->iconSize(IconSize::Small)
    ->label('Login as'),

The comparison style is to Filament's pre-built actions in v3 which you may want to stay consistent with:

Tables\Actions\EditAction::make(),
Tables\Actions\DeleteAction::make(),
Tables\Actions\ForceDeleteAction::make(),
Tables\Actions\RestoreAction::make()

from filament-impersonate.

Hmm. I don't think we set a label for the table action, since it's usually desirable to just show an action with no label when it's inline.

I bet you could do Impersonate::make()->label('Impersonate')->redirectTo('/admin') yourself in the group, can you try that?

Not sure what the best solution here is. I like it being just an icon when inline, but clearly it needs a label in a group like this.

from filament-impersonate.

Hmm. I don't think we set a label for the table action, since it's usually desirable to just show an action with no label when it's inline.

I bet you could do Impersonate::make()->label('Impersonate')->redirectTo('/admin') yourself in the group, can you try that?

Not sure what the best solution here is. I like it being just an icon when inline, but clearly it needs a label in a group like this.

Thanks. I had already tried that but that doesn't generate label like the other elements in the group. It's not crucial; if I can find the time I'll see how this can best be achieved.

from filament-impersonate.

I changed the code for STS\FilamentImpersonate\Tables\Actions\Impersonate to this:

    protected function setUp(): void
    {
        parent::setUp();

//        $this
//            ->iconButton()
//            ->icon('impersonate-icon')
//            ->action(fn ($record) => $this->impersonate($record))
//            ->hidden(fn ($record) => !$this->canBeImpersonated($record));
        $this->icon('impersonate-icon');
        $this->color('primary');
        $this->action(fn ($record) => $this->impersonate($record));
        $this->hidden(fn ($record) => !$this->canBeImpersonated($record));
    }

And now in my Action group I get this:

and on hover:

This does look more consistent IMHO.

from filament-impersonate.

For now I've implemented a custom Action class that extends STS\FilamentImpersonate\Tables\Actions\Impersonate Filament\Tables\Actions\Action so I'm happy 😉

Thanks for this great plugin!

from filament-impersonate.

The actual solution is:

Impersonate::make()->grouped()

from filament-impersonate.