statful / statful-client-java Goto Github PK

StatfulAspect @Around definition is defined as:

@annotation(timer)

Which means that it will can intercept both method call and method execution, which most likely is not the intended behaviour.

The annotation should be defined as:

@annotation(timer) && && execution(* *(..))

Just to note that the snippet

StatfulClient client = StatfulFactory.buildHTTPClient().with()
        .token("STATFUL_API_TOKEN")
        .build();

should also have a value for host (like "api.statful.com"), because the default is 127.0.0.1.

Not sure what value do you want to have there.

While sending metrics, logs are showing the following error message even when the message is correctly sent.

Unable to send metric. Reason: OK, status: 200

On com.statful.client.domain.api.StatfulClient we should expose methods to allow ingestion of pre sampled metrics like we do for pre aggregated metrics.

The downside of this is that implementing it will make the public API a bit more complex because all methods will need to be "duplicated"

Usage of Objects::nonNull should not be present

To make sure we are enforcing this Travis should be building with jdk7 instead of 8 since just setting the source and target is not reliable.

"Note: Merely setting the target option does not guarantee that your code actually runs on a JRE with the specified version. The pitfall is unintended usage of APIs that only exist in later JREs which would make your code fail at runtime with a linkage error. To avoid this issue, you can either configure the compiler's boot classpath to match the target JRE or use the Animal Sniffer Maven Plugin to verify your code doesn't use unintended APIs. In the same way, setting the source option does not guarantee that your code actually compiles on a JDK with the specified version. To compile your code with a specific JDK version, different than the one used to launch Maven, refer to the Compile Using A Different JDK example."

https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html

When sending several metrics as a string separated by a new line character, the last one shouldn't have that character as the client will expect to read another metric.

The readme shows the default aggregations for Counter as "AVG, P90" when the defaults aggregations seem to be "SUM, COUNT".

Whenever a method overload with Double/Float argument for value is used in the StatfulClientImpl class we might be creating an invalid metric due to the output of the Double/Float toString() potentially being a value in scientific notation.

The sample rate should be added to the end of the generated metric line.

Hello, can you correct the javadoc for the timestamp to state that the timestamp should be in unix time units (seconds)

/** * Sets the namespace of the metric. * * @param timestamp Namespace as long * @return A reference to this instance */ SenderAPI timestamp(final Long timestamp);