The tdd-and-dependency-injecion-with-swift from stanley-jovel

tdd-and-dependency-injecion-with-swift's Issues

Set url on Plist

TDD-and-dependency-injecion-with-swift/TDD-and-dependency-injection-experiment/ApiWrapper.swift

Line 14 in d780aaf

let apiRoot = "https://pokeapi.co/api/v2"

Don't hardcode configs or settings, use a Plist.

Great project

Hi good started project, just some initials comments:

For JSON stuff you could use Codable, is already built in Swift stdlib and Foundation also has it's own JSONDecoder/Encoder.
There are a lot of folders with the same name, try to rename it.
When you are using Rx, try to use MVVM, that's not a rule, but for reactive programming MVVM is a good fit and everything feels more natural.

Separate files into groups and directories

Currently all of the classes are on the same directory; while the app currently is small it would be good to separate the files depending on their category/purpose.

Refactor viewDidLoad

TDD-and-dependency-injecion-with-swift/TDD-and-dependency-injection-experiment/PokemonDetailsViewController.swift

Lines 31 to 68 in d780aaf

 override func viewDidLoad() { 

 super.viewDidLoad() 

 if let pokemon = pokemon { 

 pokemonNameLabel.text = pokemon.name?.capitalized 

 apiWrapper?.getPokemonWith(id: pokemon.name!).subscribe( 

 onSuccess: { pokemon in 

 self.pokemonImageView.kf.setImage( 

 with: URL(string: pokemon.sprite!), 

 placeholder: self.activityIndicator as! PlaceholderView 

 ) 

 let dataSource = RxTableViewSectionedReloadDataSource<SectionOfPokemonDetails>( 

 configureCell: { dataSource, tableView, indexPath, item in 

 let cell = tableView.dequeueReusableCell(withIdentifier: "Cell", for: indexPath) 

 cell.textLabel?.text = item.capitalized 

 return cell 

 } 

 ) 

 dataSource.titleForHeaderInSection = { dataSource, index in 

 return dataSource.sectionModels[index].header 

 } 

 let sections = [ 

 SectionOfPokemonDetails(header: "Types", items: pokemon.types ?? []), 

 SectionOfPokemonDetails(header: "Abilities", items: pokemon.abilities ?? []), 

 SectionOfPokemonDetails(header: "Moves", items: pokemon.moves ?? []), 

 ] 

 Observable.just(sections) 

 .bind(to: self.detailsTableView.rx.items(dataSource: dataSource)) 

 .disposed(by: self.disposeBag) 

 } 

 ).disposed(by: disposeBag) 

 } 

 }

Method is too big and complex, would be nice to make a refactoring.

stanley-jovel / tdd-and-dependency-injecion-with-swift Goto Github PK

tdd-and-dependency-injecion-with-swift's People

Contributors

Stargazers

Watchers

tdd-and-dependency-injecion-with-swift's Issues

Set url on Plist

Great project

Separate files into groups and directories

Refactor viewDidLoad

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	override func viewDidLoad() {
	super.viewDidLoad()

	if let pokemon = pokemon {
	pokemonNameLabel.text = pokemon.name?.capitalized
	apiWrapper?.getPokemonWith(id: pokemon.name!).subscribe(
	onSuccess: { pokemon in
	self.pokemonImageView.kf.setImage(
	with: URL(string: pokemon.sprite!),
	placeholder: self.activityIndicator as! PlaceholderView
	)

	let dataSource = RxTableViewSectionedReloadDataSource<SectionOfPokemonDetails>(
	configureCell: { dataSource, tableView, indexPath, item in
	let cell = tableView.dequeueReusableCell(withIdentifier: "Cell", for: indexPath)
	cell.textLabel?.text = item.capitalized

	return cell
	}
	)

	dataSource.titleForHeaderInSection = { dataSource, index in
	return dataSource.sectionModels[index].header
	}

	let sections = [
	SectionOfPokemonDetails(header: "Types", items: pokemon.types ?? []),
	SectionOfPokemonDetails(header: "Abilities", items: pokemon.abilities ?? []),
	SectionOfPokemonDetails(header: "Moves", items: pokemon.moves ?? []),
	]

	Observable.just(sections)
	.bind(to: self.detailsTableView.rx.items(dataSource: dataSource))
	.disposed(by: self.disposeBag)
	}
	).disposed(by: disposeBag)
	}
	}