stankovski / prayer-times Goto Github PK

Asalamu alaikum wa rahmatullahi wa barakatu akhi,

The line :
if (this.HighLatitudeAdjustmentMethod == HighLatitudeAdjustmentMethods.AngleBased)
return 1 / 60 * angle;

Should be :
if (this.HighLatitudeAdjustmentMethod == HighLatitudeAdjustmentMethods.AngleBased)
return 1d / 60d * angle;

Without this, the fraction returns 0 ( as it does integer division and returns a whole number), by setting the values to doubles a fraction is returned and angle based calculations work correctly.

Jazakallahu khairan for your good work.

Nad

This is not real Muslim times. The times are not correct.

Salam aleykum
Please check the "EffectiveTimeZone()" in "PrayerTimesCalculator"
it should be like that

private int EffectiveTimeZone(DateTimeOffset date, int? timeZone)
        {
            if (timeZone == null)
                timeZone = date.Offset.Hours;

            int dstOffset = 0;
            if (date.LocalDateTime.IsDaylightSavingTime())
            {
                dstOffset = -1;
            }

            return timeZone.Value - dstOffset;
        }

CalculationMethods.Custom can be used, but the values for this are hard-coded and the same as the Muslim World League, making it useless. Additional properties should be used to allow any custom angles to be used.

try this test..

        PrayerTimesCalculator calc = new PrayerTimesCalculator(53.4794892, -2.2451148);
        calc.CalculationMethod = CalculationMethods.MWL;
        calc.AsrJurusticMethod = AsrJuristicMethods.Shafii;
        var times = calc.GetPrayerTimes(new DateTime(2020, 5, 14), 1);

it will return NaN for FAJR time.