stanford-cs248 / shading Goto Github PK

If one looks carefully at the shadow of the smaller spheres, they will notice that when the light shines on it from a low angle and should cast a long shadow, the rendered shadow is a round shape (instead of a elongated shape) that is detached from the bottom of the sphere.

Using 0.0005 instead of 0.005 for shadow bias seems to give more correct shadows. Shadow shader should be updated and all screenshots in README should be updated too. I'm just filing this as a TODO so that we don't forget.

Unfortunately the assignment is already due for 2020 Winter iteration, so we should update this before next time the assignment is released.

The spheres_shaodw.json scene places 3 big spheres on the same plane that is the floor, but the right-most sphere has its bottom poking below the floor.

It is unclear what is wrong, as the old version of the assignment exhibits the same problem.