stanfieldr / ghetto-skype Goto Github PK

when the image is display or the text,
there is no way to go back to the default view

The settings in skype for web can be accessed over the little status icon at the top left on the profile or when you pull down the huge settings thing by clicking on your name where you can also change your profile picture.

When a user uploads an image or direct pastes it into chat, clicking this image brings out the image in Skype's API through a browser at a URL similar to https://eus1-api.asm.skype.com/$path_to_image

When the page loads Skype returns an authentication error:

ghetto-skype does not seem to remember the size to which I resized its window after I quit and restart the application. This is inconvenient, as I find the default window size too small.

Under Kubuntu 16.04, instead of the actual icon in the application data files (the letter S in a blue or red circle), I get two blue or red rectangles.

Hopefully the title makes sense. At least on Ubuntu Gnome, if I minimize to tray and then click the shortcut on my dock it loads another instance of the program rather than open another. I use about 3 Electron based applications that minimize to tray and this is the only one that does it, although they each behave slightly different.

Here's a screenshot of what I'm talking about:

Figured I'd just let you know. Normal behavior is to bring the app to the foreground.

when I click on links someone sent me it opens the link I opened as well as https://web.skype.com/en/undefined

Ghetto is working mostly fine, but one small issue is that when I click on notifications, Ghetto window isn't brought up.

Hi friends could you soon add the possibility to compile this app for 32 bit operating systems? actually Skype for Linux's video and audio calls are not working because of how old are the last official Skype builds for Linux so could be amazing to be able to use Skype on our PC with this app

Ubuntu 16.04
when launching from app menu the launcher icon appears for a few seconds, no window appears.
Starting from terminal

 ~/: npm --prefix /opt/ghetto-skype start

> [email protected] start /opt/ghetto-skype
> electron .

No window.

This is a bug. Even when I don't have any unread messages, the icon remains red.

Hello,
When using dark theme if you want to block some user you can't read text inside window.

Under KDE Plasma 5.5 (Ubuntu 16.04), when I add ghetto-skype to autostart using the application settings, it does not load properly, instead showing a blank white window when I right click the icon and select "Open". No notifications are present, either.

I suspect that the problem is related to the fact that the Wi-Fi connection is not yet active when KDE autostarts the program. I tried starting it after manually disconnecting, and got the same result: a blank white window. Connecting afterwards does not fix the problem once ghetto-skype is already launched, and the window remains blank white. Unlike regular Skype for Linux, it seems ghetto-skype does not listen to network connection status changes and does not try to connect once the network is up. It should probably listen to network-manager events via D-Bus.

This or something similar could help: https://www.npmjs.com/package/nm-dbus

Problem

Web Skype uses CSS in such a way that makes it difficult for the themes to have more specificity. Additionally the user must know CSS in order to make their own themes.

Solution

Learning from the dark theme, we can take the main CSS file and use it as a template. We can then make all the colors into variables and functions. These variables would hold the colors and would be placed in the theme folder. This allows us to maintain multiple themes easily when Skype updates their CSS selectors. It also means the theme developer doesn't need to know CSS or worry about the hassles associated with overriding Skype's CSS.

I lock my screen and leave ghetto-skype open for long periods of time. When I come back to it, it appears as if I'm still logged on - however, I cannot receive messages and sending messages doesnt work either.

Frustrating as you can easily not see messages for a long time. I've resorted to restarting it every time I login.

In the 4.3 client you don't see pop-ups when a message has arrived. Is it possible to add a setting to not show the system notification pop-up when message has arrived. A fine grained setting that allows to show pop-up in case of mention by @usernames would be nice.

When connecting from an environment required to forward request through a proxy, the startup page stays white. Is the a possibility to define a proxy server through the config file?

Whenever I make a call, I need to hang up at the other end, because the button doesn't work.

Also, I have the "Please install our shit" whenever I want to answer a recieved call.

But, This is remarkable work and you deserve tons of kudos for that one

After installing the RPM on openSUSE Tumbleweed when I go to make or receive a call it still asks to install the Skype for Web plugin.

This is obviously a real problem as it defeats the point of using Ghetto Skype at all.

Why not make it as easy as:

$ npm install -g ghetto-skype

This pops up whilst installing/upgrading the package on Ubuntu.

I accidentally checked the Microsoft Account option in settings and now I can't uncheck it.

I've uninstalled it twice, but the settings are still kept somewhere. Any quick workaround to purge everything related to ghetto until a fix is provided?

this is the output:

comtom@andarta:~/tmp/ghetto-skype$ npm install
npm WARN engine [email protected]: wanted: {"node":"~5.5.0","npm":"~3.3.12"} (current: {"node":"4.4.7","npm":"1.4.21"})
npm WARN deprecated [email protected]: Critical security bug fixed in v7.0.0 - read more at electron/packager#333
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

[email protected] postinstall /home/comtom/tmp/ghetto-skype/node_modules/electron-prebuilt
node install.js

sh: 1: node: not found
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

npm ERR! [email protected] postinstall: node install.js
npm ERR! Exit status 127
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is most likely a problem with the electron-prebuilt package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node install.js
npm ERR! You can get their info via:
npm ERR! npm owner ls electron-prebuilt
npm ERR! There is likely additional logging output above.

npm ERR! System Linux 4.6.0-1-amd64
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /home/comtom/tmp/ghetto-skype
npm ERR! node -v v4.4.7
npm ERR! npm -v 1.4.21
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /home/comtom/tmp/ghetto-skype/npm-debug.log
npm ERR! not ok code 0

I'm using Linux Mint 18 Cinnamon and I favorited a conversation in Skype and that conversation doesn't show up in ghetto skype. It wasn't showing before I favorited it either. Is there a size limit to conversations?

As soon as my friend tried sharing screens, the call immediately closed.

Not sure if the skype service is down or not. But after updating to version 1.3.0 it didn't work anymore.
Calls are not connecting..

ghetto version : 1.3.0
Ubuntu 16.04

Please forgive my ignorance, but where are you getting the remote module from? I don't see it listed as an explicit dependency.

Its purpose seems to be to be able to load the tray.js module from this subdirectory views/ and still have all the require()'s in that file reference the correct module path. I'm trying to package the latest version for the AUR, and would like to keep this package decoupled from electron so we can use a globally installed copy of electron and simply /usr/bin/electron /opt/ghetto-skype, which also saves ~40mb per electron app.

Simply adding remote as a dependency and npm install --production does not seem to work, it looks like that module ships as a coffee script library and may require compilation before use, but I may be missing something. Furthermore, it looks like that module isn't even related to how it is being used in this context...

My initial attempt to fix this was to just require tray.js relatively (ex, require('../tray'); in views/skype.js), but then require('electron') doesn't resolve anymore, which I think is due to the way require() searches for modules in this specific case.

Do you have any suggestions for resolving this for users with external copies of electron, or is this going to be an unsupported configuration?

I'm not entirely opposed to using a bundled electron, but if I can save 40mb for every electron app and pay it once, I'd rather be able to do that.

Would be nice to get updates through Ubuntu ppa using https://launchpad.net or repository using https://build.opensuse.org/

I have some issues (along with many linux users) where my laptop's microphone has 2 channels and if they are in the same levels they cancel its other out and no sound is incoming (don't ask me why, I'm not sure).

Ghetto skype automatically brings the levels of the channels at the same range if there is loud sound (it probably tries to adjust the microphone volume), but in normal skype you can configure it to not do so. Is it possible to have this option here as well ?

As always thank you

Here's a video: https://www.youtube.com/watch?v=yGb-6Z_BQw8

The refreshing never stops, it just keeps refreshing. I let it sit for 5 minutes just to be sure.

This occurs on Ghetto Skype 1.3.0 and 1.2.3. This issue does not occur on version 1.2.2.

I have tried deleting the folder ~/.config/Ghetto Skype and using sudo apt purge -y ghetto-skype each time to be sure I'm starting with a clean slate when I re-install it but this issue still occurs.

Details

If you select quit from the menu in gnome, ghetto-skype does not exit. I encountered this while working on the aur package as I was starting and stopping many instances. A normal user probably won't stop then restart the application very often.

Steps to reproduce

1. Start ghetto-skype either from the desktop shortcut or directly with electron
2. In the application menu, select Quit

Expected Behavior: ghetto-skype quits, and the main electron process exits

Actual Behavior: the electron process does not quit and must be killed. Until this is done, the tray icon remains.

Workaround

Select Exit from the tray icon instead.

When using the dark theme, and I right click on a conversation and choose "delete conversation" the emergin window has no text, but it does if I am using the light text.

After a second or two after audio call start on Ubuntu 16.04 LTS 64-bit it is dropped with "Call ended message". The receiver does not see any call, there is no "Missed call" message. The "outgoing call" sound is also not played during this attempt.

The Icon changes color, but doesn't show any toast :(

It seems that if you're using an external copy of electron-prebuilt, you need to bet BrowserWindow from electron.BrowserWindow instead of require('browser-window').

I plan on opening a PR for this. If there is a better way that this should be done, please let me know, as I'm pretty new to nodejs.

When I click on the system tray icon, the ghetto client is not brought to the foreground. The window is opened in the background, forcing me to click again on the application window to bring the client to the foreground.

I'm running Plasma5 if that matters.

Thanks for your amazing app.

When I click the tray icon the client is minimized. Isn't it possible to bring it to front and to remember last window setting ?

Thanks once more

Rather than using make, it would be nice to be able to install Ghetto Skype with a package manager.

It would be really nice if you could add notification support (I'm using dunst as daemon). If I find the time to implement it, I'll send you a pull request...

Would be great, if possible!

Thanks.

subj

You should be able to drop a folder containing css into a "themes" directory and change the theme via settings.

There should be an ability where the user can upload his or her own custom icon for Skype. As it is right now, the Ghetto Skype icon is half-and-half light blue and dark blue, which is quite irritating, but I'm assuming that the developer did it for copyright reasons. I'd love to use the actual icon of Skype.

Since Microsoft released their Skype "client" (which is much worse than Ghetto-Skype, and it doesn't even let me login), they allow calls from Chrome/ium. Change the browser id of Ghetto-Skype and make it even better!

Not exactly sure what causes the settings to get reset, but all settings reset except autostart goes back to the default settings. Needs investigation, difficult to reproduce

Text messages doesn't work if your contacts use an older version of Skype.
I have tried to send few text messages to my friend with Skype for Linux. But he didn't receive anything

Ghetto version v1.3.2
lsb_release -a
Distributor ID: Ubuntu
Description: Ubuntu 16.04 LTS
Release: 16.04
Codename: xenial

Is there any way to make jack support?

Hello,

I'm not sure way but it is always redirecting me to microsoft login. I guess the problem is in views/skype.js:heckMicrosoftAccount(currentURL)

I added the dumb condition:

if ('0'=== '0') {

       }

        else if (currentURL.hostname === "login.skype.com" && currentURL.query.client_id)

to force skipping microsoft login. I guess the original condition is not ok...

BTW the settings.json is ok:

cat settings.json 
{
    "StartMinimized": false,
    "MicrosoftAccount": false
}

Allow users to send encrypted messages through Skype and automatically encrypt before sending and decrypting before displaying to user.