stampit-org / react-stamp Goto Github PK

In your exemple, you're using rest+spread on behavior object.

import reactStamp from 'react-stamp';

export default ({
  React,
  Button,
  Text,
}, ...behaviors) => (
  reactStamp(React).compose({
    state: {
      showText: false,
      clickable: false
    },

    render () {
      const { clickable, showText } = this.state;
      const { text } = this.props;

      return (
        <div>
          <Button
            disabled={!clickable}
            onClick={() => this.onClick && this.onClick()}
            value='click me'
          />
          <Text
            value={showText && text}
          />
        </div>
      );
    }
  }, ...behaviors)
);

But as fas as I understand react-stamp composition, it should be possible to just send behavior.

import reactStamp from 'react-stamp';

export default ({
  React,
  Button,
  Text,
}, behaviors) => (
  reactStamp(React).compose({
    state: {
      showText: false,
      clickable: false
    },

    render () {
      const { clickable, showText } = this.state;
      const { text } = this.props;

      return (
        <div>
          <Button
            disabled={!clickable}
            onClick={() => this.onClick && this.onClick()}
            value='click me'
          />
          <Text
            value={showText && text}
          />
        </div>
      );
    }
  }, behaviors)
);

Did I miss something?

Version 6.24.1 of babel-cli just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-cli is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hello,

i've spent hours to figure out what's wrong with my react project and it appears that react-stamp is incompatible with stamp-utils 1.3.1 (or maybe 1.3.1 has bug)

Actually, with this simple component,

const C = reactStamp(React).compose({
  render() {
    return <div>My react stamp component</div>
  }
})

the compose method remove render because stamp-utils.isDescriptor({ render() {...} }) return true with version 1.3.1 but not with version 1.2.4.

Could you please change carret with tilde on stamp-utils to avoid to use 1.3.1 version ?

  "dependencies": {
    "lodash": "^4.6.1",
    "stamp-utils": "~1.2.4"
  },

I know stampit v2 has dropped IE8 support.

Since this library is specifically for React, does it support IE8, as React does?

Hi,

displayName is missing from the reactDesc interface in docs/api.

Hey, guys!

Thanks for the awesome library!
I find this approach way more better than common one, just one thing.. How to enable hot-module-reload with webpack?

Thanks!

A recent issue over at the React repo (facebook/react#5047) got me thinking.

When I wrote this library originally (react-stampit), I wanted to enforce composition logic similar to React.createClass. More about this is described in the docs here. But after reading and thinking about the above React issue, maybe this is the wrong thing to do. What if react-stamp simply stuck to the composition logic layed out in the stamp spec while providing the React-like API? No method wrapping, no duplicate key checks, just assign/merge all properties with last-in priority.

I'm having trouble coming up with examples favoring the current composition logic.

cc @ericelliott

Version 6.23.1 of babel-core just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-core is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

With the new composables specification the following:

const container = ({
  React,
  Button,
  Text,
}, ...behaviors) => (
  reactStamp(React).compose({
    state: {}
    render(){}
  })
);

const MyComponent = container({
  React,
  Button: button(React),
  Text: text(React),
}, buttonBehavior);

can be now improved to

const MyComponent = reactStamp.compose(
  React,
  Button: button(React),
  Text: text(React),
  buttonBehavior,
  {
    state: {},
    render(){}
  });

or even

const MyComponent = reactStamp
.compose(React)
.compose({
  Button: button,
  Text: text
})
.compose(buttonBehavior)
.compose({
  state: {},
  render(){}
});

Something like that. Up to you actually. :)

@troutowicz what do you think?

Now when React Hooks are available providing composability out of the box, it doesn't seem that stamps provide any benefit. According to NPM, there is still a couple of downloads, some legacy projects I assume. Besides, there was no activity since 2016 in regards to issues or anything.

Should we deprecate this project?

Version 15.5.1 of react-addons-test-utils just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react-addons-test-utils is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 7.2.0 of babel-eslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

{
  "parser": "babel-eslint",
  "parserOptions": {
    "codeFrame": false
  },
  "extends": "eslint:recommended"
}

Your Greenkeeper Bot 🌴

module.js:340
throw err;
^
Error: Cannot find module '.'

Version 15.5.2 of react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 6.24.1 of babel-preset-stage-2 just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-preset-stage-2 is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

In addition to the excellent improvements in #17, I think it would be really helpful to see a real code example (even if contrived) of using stamp.compose() directly in the README.

Version 2.6.0 of rimraf just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As rimraf is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Just an idea, I'm not sure if it doesn't collide with something else at this point, but what about defining component like this:

const MyComponent = () => ({
    render() {
    }
});
export default ReactStamp.compose(
    MyComponent, Focusable, Emittable
);

It means that it would have to call passed function to a compose to obtain a descriptor. Along the way it would be possible to read displayName of that function and append into final descriptor. I also like it this way as final composition is more readable.

Version 6.3.0 of babel-loader just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-loader is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 15.5.0 of react-addons-test-utils just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react-addons-test-utils is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

The README could be better.

• define composition
• provide example using Behavior Driven Composition
• recommend when to use stamps over HOCs
• make it clear this is not React.createClass 2.0

BDC example: http://codepen.io/troutowicz/pen/BoZqXX?editors=001

Version 6.24.0 of babel-preset-es2015 just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As babel-preset-es2015 is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 15.5.3 of react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 15.5.1 of react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hi
there's a way to avoid the use of bind for custom handler?
http://esnextb.in/?gist=5c9399dfdde739723b7f3f22a32157dd

import React from 'react';
import ReactDOM from 'react-dom';
import reactStamp from 'react-stamp';

const container = {
  state:{
    val: 'click me'
  },
    clickMe(evt) {
        this.setState({val: 'clicked'});
    },
    render() {
      const newHandler = this.clickMe.bind(this);
        return (
            <div className="clearfix">
                <a onClick={newHandler}>{this.state.val}</a>
            </div>
        );
    }
}
const DummyComponent = reactStamp(React).compose(container);
const domHandle = document.getElementById('js-react-entry');
ReactDOM.render(<DummyComponent />, domHandle);

it seems that in this way it doesn't works

import React from 'react';
import ReactDOM from 'react-dom';
import reactStamp from 'react-stamp';

const container = {
  state:{
    val: 'click me'
  },
    clickMe(evt) {
        this.setState({val: 'clicked'});
    },
    render() {
      const handler = this.clickMe;
        return (
            <div className="clearfix">
                <a onClick={handler }>{this.state.val}</a>
            </div>
        );
    }
}
const DummyComponent = reactStamp(React).compose(container);
const domHandle = document.getElementById('js-react-entry');
ReactDOM.render(<DummyComponent />, domHandle);

Version 15.5.0 of react just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 3.15.0 of eslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

It's something that ES6 classes kinda suffer from that all methods you want to pass as a callback has to be manually bound to this. It seems to me that stamps kinda suffer same thing compared to React.createClass that is doing autobind.

So I am wondering how to approach this in here. Manual bind in initializer or directly in callback seems just awkward to me. However full autobind might have some unwanted effects too with mixing various behavior to the stamp, some of those methods might want to keep their original context.