stacktracejs / stack-generator Goto Github PK

Given the function source:

function () {
  // set the script that called this function
  updateLastScript(script)
  // immediately unset it
  _setTimeout(function () { updateLastScript(null) }, 0)
  cb.apply(this, arguments)
}

this Regex will incorrectly name the function updateLastScript which is an unfortunate sequence of a comment ending in function followed by a function call.

a nested function definition can also trip it up:

function () {
  function jim() {
    // inner
  }
  more()
  statements()
}

The following update fixes these scenarios, correctly returning null for these two annonymous functions:

- if (/function(?:\s+([\w$]+))+\s*\(/.test(curr.toString())) { 
+ if (/^\s*function(?:\s+([\w$]+))+\s*\(/.test(curr.toString())) { 

I'm not sure if the "any preceding whitespace" part is strictly necessary but I don't think it hurts to permit that.

I can put together a PR for this including tests but I wanted to post it up as an issue before I get around to that while I work around it.

Can you please clarify this statement?

If this pertains to the "use strict" JavaScript directive, what does that entail? Does it work on pages where some of the scripts you're tracing through use strict mode, or does this limitation apply to the calling script only?

Thanks 🙂

Two possible approaches:

• Stringify all arguments with Object.prototype.toString.call(arg)
• Leave arguments alone and use them as is

Perhaps an option could be introduced that takes one approach or the other.