st-tu-dresden / videoshop Goto Github PK

The more commonly used term to what we currently describe as Basket is called Cart. Salespoint 6 RC1 will have it's API changed to accommodate this scenario so we should align our wording accordingly.

See http://docs.spring.io/spring-boot/docs/1.3.x/reference/htmlsingle/#using-boot-devtools for details.

https://github.com/st-tu-dresden/videoshop/blob/master/src/main/java/videoshop/VideoShopDataInitializer.java#L140

Use "Role.of(...)" instead of deprecated "new Role(...)"

See this ticket for reference.

org.hibernate.LazyInitializationException while performing a test without the scope of the EntityManager.
Solution: @transaction

Requires upgrading to Moneta.

The customer management should be improved:

• Create a dedicated package for all customer management related functionality
• Extract logic of UserAccount creation and customer creation into a transactional service (currently the logic in ShopController.registerNew(…) consists of two steps and is not transactional).
• Turn RegistrationForm into a domain type.
• Extract dedicated controller and expose functionality in a more idiomatic way.

Test cases in Videoshop are named Abstract but aren't abstract classes, actually. The Surefire plugin is configured to skip these in a Maven build but running the test cases in the IDE will cause errors. The classes should be made abstract.

Current Salespoint (6.0 RC1) doesn't have @EnableGlobalMethodSecurity(prePostEnabled = true) activated (as we just discovered in the lecture today). There's already a ticket for that in Salespoint which will be resolved for the 6.0 GA release. To keep the VideoShop working in the meantime we should temporarily add the annotation to the configuration to make sure the security constraints defined on the controllers are actually evaluated.

Remove security configuration temporarily introduced for #19.

If i add a BlueRay to the basket and open the basket i get the following error:

org.thymeleaf.TemplateEngine:1085 - [THYMELEAF][http-nio-8080-exec-6] Exception processing template "basket": Exception evaluating SpringEL expression: "basket.price" (basket:52)

cat].[localhost].[/].[dispatcherServlet]: 182 - Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is org.thymeleaf.exceptions.TemplateProcessingException: Exception evaluating SpringEL expression: "basket.price" (basket:52)] with root cause
org.springframework.expression.spel.SpelEvaluationException: EL1008E:(pos 7): Property or field 'price' cannot be found on object of type 'org.salespointframework.order.Basket' - maybe not public?

Downgrading the hsql dependency to, e.g. 2.2.9 will fix this problem, but with the newest version 2.3.3 you have the problem described below:

Steps for reproducing:
Adding a field and corresponding getter & setter, e.g. in the Disk class:

private int fsk;

Adding a request-Mapping in Catalogcontroller:

@RequestMapping(value = "/fsk", method = RequestMethod.POST)
public String comment(@RequestParam("pid") Disc disc, @RequestParam("fsk") int fsk) {
        disc.setFsk(fsk);
        videoCatalog.save(disc);
        return "redirect:detail/" + disc.getIdentifier();
}

The .save Operation will throw a org.hsqldb.HsqlException: data exception: string data, right truncation Error.

See the related question in Auditorium.

See this question in Auditorium.

As a consequence, no errors are shown above the <input>-fields in the html form.

Triggered by fixing #51 .

UserAccounts not being initialized correctly

Some sections in "videoshop/readme.adoc" refer to the guestbook-tutorial, I guess they were just copy-pasted there.

Same as st-tu-dresden/kickstart#14

We're still using the variable name orderline in cart.html which seems to cause confusion about the type of the items held in Cart. We should rename the variable to item to reflect it not being related to OrderLines in the first place.