srishkee / janeeyre Goto Github PK

Great job in general! Really glad you got the chance to work on this project, and hopefully you found it useful.

Your final analysis PDF looks amazing!! Did you create a physical project board?? it looks like it could be a poster board but I wasn't sure 😂

A few thoughts:

• Love all the comments you have for the functions! For some functions (getWordAfter?), I think it would be more helpful to have a top level comment instead of multiple in line comments. That way, if someone (or yourself) is reading the code, you can get a quick gist of how the methods function
• One thing I think would be really useful to add is a README for this project. Having a README for your GitHub projects lets recruiters / future employers / anybody take a quick look at the project and know what it’s about. You can put in a couple sentences to describe the general idea of the project and the technical challenges you faced, and definitely that cool 'poster board' you created

Feel free to ping me if you have questions about anything!