Git Product home page Git Product logo

quotes-collection's People

Contributors

sriniguna avatar tailorvj avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

quotes-collection's Issues

Add filter to options

I would like to add filter actions to the quote options. I added it to the source code like so:

class-quote-collection-quote.php

$options = apply_filters('quotescollection_options',array_merge( $default_options, $options ));

Would you be so kind to pull this into the source?

WPML compatibility

It would be really nice to add WPML compatibility - allowing quotes to be in translated.

Needs Update For PHP7

Hi, I cannot update my WP site due to this plugins incompatibility with PHP. Are you planning an update? Ta!

The Quotes Collection Plugin has an SQL injection vulnerability

There is an SQL injection vulnerability at the 'page' parameter
POC:

image

image

sqlmap identified the following injection point(s) with a total of 203 HTTP(s) requests:

Parameter: paged (GET)
Type: boolean-based blind
Title: AND boolean-based blind - WHERE or HAVING clause
Payload: page=quotes-collection&s=&_wpnonce=6451483bd1&action=make_public&paged=1 AND 8236=8236&bulkcheck[]=1

[16:57:38] [INFO] testing MySQL
[16:57:38] [INFO] confirming MySQL
[16:57:39] [INFO] the back-end DBMS is MySQL
web server operating system: Linux CentOS 8
web application technology: Apache 2.4.37, PHP 7.2.24
back-end DBMS: MySQL >= 5.0.2

Import doesn't like -

Import chokes when there is a dash (-) in a quote, such as:

'I like rice. Rice is great if you're hungry and want 2000 of something.' -- Mitch Hedberg (American comic. 24 February 1968 – 29 March 2005)

Oddly, it's fine with the double-dash -- but not with the single dash. Escaping it like this - doesn't help.

I tried replacing with an n dash and an em dash, but that didn't help, either, oddly.

The import also hates any accents. That made it tough; I was importing 900 quotes about food, and there's a lot of French accents happening when you are talking about food.

I ended up having to do the import in batches of 3's, 7, 10s, etc and as it refused to import, examine each batch to see what was making it unhappy this time.

Oddly, my JSON formatting passed all JSON linters with flying colours! Oh well!

How can I add multiple columns in desktop view

Quote page generated from this plugin are in single column. I wrote some css code and give the class to advance setting in Gutenberg. but it does not replact.

[@media only screen and (max-width: 500px) {
 #quotescollectionabc {
  column-count:1;
  text-align:center
  list-style-type: none;
margin-top: 20px;
margin-bottom: 30px;
 }
}
	
@media only screen and (min-width: 501px) and (max-width: 1024px) {
 #quotescollectionabc {
  column-count:2;
  column-gap:20px;
  list-style-type: none;
  margin-left:30px;
  margin-bottom:20px;
 }
}
	
@media only screen and (min-width: 1025px) {
 #quotescollectionabc {
  column-count:3;
  column-gap:20px;
  list-style-type: none;
  margin-left:30px;
  margin-bottom:20px;
 }
} ](url)

Its seems this plugin author is not aware of this plugin anymore, if anyone expert pla help me out.

Theme crash due the name of the class "title" in Widget

At line 122 from file class-quotes-collection-quote.php:

	if( $options['show_source'] && $options['show_source'] !== 'false' && $this->source ) {
		if($attribution) $attribution .= ", ";
		$attribution .= '<cite class="title source">' . $this->source . '</cite>';
	}

Look at tag cite, it have: class="title source"
The class title is very comum in Wordpress themes. I suggest change the name of the class or put a prefix.

In some themes the source text in the quotation stay big too much due this name class.
Thank you and congratulations by the software.

Import choking

Import chokes when there is a dash (-) in a quote, such as:

'I like rice. Rice is great if you're hungry and want 2000 of something.' -- Mitch Hedberg (American comic. 24 February 1968 – 29 March 2005)

Oddly, it's fine with the double-dash -- but not with the single dash. Escaping it like this - doesn't help.

I tried replacing with an n dash and an em dash, but that didn't help, either, oddly.

The import also hates any accents. That made it tough; I was importing 900 quotes about food, and there's a lot of French accents happening when you are talking about food.

I ended up having to do the import in batches of 3's, 7, 10s, etc and as it refused to import, examine each batch to see what was making it unhappy this time.

Oddly, my JSON formatting passed all JSON linters with flying colours! Oh well!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.