Japanese `readtime.other` shows a full-width `＃` instead of the correct number about mkdocs-material HOT 7 CLOSED

Thanks for reporting! Fixed in bde889f.

Yes, we're currently not able to use full-width numbers, so switching to half-width to be consistent is likely to be our best option. We could add whitespace left and right, if that makes reading any easier, but then we should also adjust that for:

  "search.result.more.one": "このページ内にもう1件見つかりました",
  "search.result.more.other": "このページ内にあと#件見つかりました",

We'll be working on improving internationalization in the future, as we want to provide the best experience possible!

from mkdocs-material.

FYI, whether or not to add spaces around half-width characters within Japanese sentences is a point of contention. My preference is to add spaces, but there are also people who don't like it. Even within a single company, there is no consistency. For example, spaces are added in the UI within macOS, but not on Apple's website (apple.com).

Thanks for the clarification! Then let's just leave it like that for now, as translations can also be quite simply overridden. I'll let you know when we start working on better translations support ✌️

Let's keep this issue open until released ☺️

from mkdocs-material.

Released as part of 9.5.19

from mkdocs-material.

Screenshots

English (correct):

Japanese (incorrect):

from mkdocs-material.

By the way, currently the translation for readtime.one is "このページは約１分で読めます" ("This page takes about 1 minute to read"). The "１" here is a full-width character.

But for numbers greater than 1 (in the case of readtime.other), a half-width character is used. To improve consistency, I think it would be better to use a half-width "1" for readtime.one as follows:

このページは約1分で読めます

from mkdocs-material.

@squidfunk

Thank you for your quick response! I have confirmed that the issue has been resolved by running a sample with master after bde889f :D

We could add whitespace left and right, if that makes reading any easier, but then we should also adjust that for:

You are right. FYI, whether or not to add spaces around half-width characters within Japanese sentences is a point of contention. My preference is to add spaces, but there are also people who don't like it. Even within a single company, there is no consistency. For example, spaces are added in the UI within macOS, but not on Apple's website (apple.com).

If there is an opportunity in the future when internationalization is improved, I would love to contribute.

I will close this issue. If there are any problems, please reopen it. Thanks :)

from mkdocs-material.

Yay! Thank you.

Yes, please reach out when the time comes ✌️

from mkdocs-material.