Git Product home page Git Product logo

Comments (9)

Lakedaemon avatar Lakedaemon commented on August 10, 2024

I did another experiment : I added a loging command to the commented line :
if (context.getSystemService("PATH_CONTEXT") == null) {
L.info("not a path context $context ${(context as? ContextWrapper)?.getBaseContext()}")
throw Exception("not a path context $context ${(context as? ContextWrapper)?.getBaseContext()}")
}

And I got interesting results :

  1. getContext() of both views are actualy NOT wrapped with a PathContext (the 2 lines appeared in logcat)
  2. adding an exception with the commented line must have trigger a catch block somewhere that swallows my exception and that makes the code work (bad luck, I was hoping to find where the problem was coming from that way)

from flow.

Lakedaemon avatar Lakedaemon commented on August 10, 2024

Another experiment with print debug statements.
It looks like the error comes from this part of the code :
val context = PathContext.create(oldPath, to, contextFactory)
val layout = getLayout(to)
val newView = LayoutInflater.from(context).cloneInContext(context).inflate(layout, containerView, false)

My print statements tell me that context is able to deliver a PathContext but not newView.getContext()
Which is weird as I guess that the cloneInContext part was all about using a layoutInflater set with the good PathContexted context...
Let's now grep LayoutInflater

from flow.

Lakedaemon avatar Lakedaemon commented on August 10, 2024

I looked into the chains of ContextWrapper.
newView.getContext() has :
org.lakedaemon.android.flow.MyFlowActivity@427b02c8
android.app.ContextImpl@42807fe0

context has :
flow.path.PathContext@428fc308
flow.path.Path$LocalPathWrapper@428fc2c8
org.lakedaemon.android.flow.MyFlowActivity@427b02c8
...

Also I checked LayoutInflater.from(context).cloneInContext(context)
the Context it holds is identityEquals to context
So the issue certainly comes from inflate(layout, containerView, false)

When I grepped the LayoutInflater code, it seemed to me that there might be a possibility the context could be changed (when a view uses a theme...)

from flow.

almozavr avatar almozavr commented on August 10, 2024

@Lakedaemon Do you use AppCompatActivity from 22.1.+? If so, there is a know issues with misusing context during inflation (see workaround inside): #88 (dig into mortar issue)

from flow.

Lakedaemon avatar Lakedaemon commented on August 10, 2024

Yes I'm using AppCompatActivity (to get support for the api range 9 to 22) and I believe that I suffer from this exact issue. Thanks for the pointer.

from flow.

Zhuinden avatar Zhuinden commented on August 10, 2024

To fix this, just use LayoutInflater.from(context.getApplication()).cloneInContext(context).inflate(...)

from flow.

Zhuinden avatar Zhuinden commented on August 10, 2024

And you also need to initialize your container view group like this

PathContext pathContext = PathContext.root(this);
    framePathContainerView = (MortarScreenSwitcherFrame) LayoutInflater.from(this)
            .cloneInContext(pathContext)
            .inflate(R.layout.activity_main, null);
setContentView(framePathContainerView);

from flow.

Lakedaemon avatar Lakedaemon commented on August 10, 2024

Thanks for the tip. It really helped.

from flow.

loganj avatar loganj commented on August 10, 2024

See also #91

from flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.