I have encountered an issue where the history size shrinks while a traversal is in-fli

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

New way to break Flow.goBack() about flow HOT 3 OPEN

dcow commented on August 10, 2024

New way to break Flow.goBack()

from flow.

Comments (3)

Zhuinden commented on August 10, 2024

So I'm guessing the problem is that it does a return; and not an immediate onTraversalCompleted() (which wouldn't work because it's not technically "dispatched"), and therefore somehow you can enqueue ops after the enqueued goBack() but it is not started because of return; instead of starting the next enqueued traversal if possible?

flow/flow/src/main/java/flow/Flow.java

Lines 331 to 341 in 2982c5e

 pendingTraversal = next; 

 if (pendingTraversal == null) { 

 final Iterator<Object> it = tearDownKeys.iterator(); 

 while (it.hasNext()) { 

 keyManager.tearDown(it.next()); 

 it.remove(); 

 } 

 keyManager.clearStatesExcept(history.asList()); 

 } else if (dispatcher != null) { 

 pendingTraversal.execute();

from flow.

Zhuinden commented on August 10, 2024

Have you figured out if my hunch was right or wrong? I mean, I haven't used Flow in a while.

from flow.

sdelaysam commented on August 10, 2024

@dcow here how I solved the issue for me
sdelaysam@4980cef

from flow.

Related Issues (20)

Documentation issues to fix for beta HOT 1
Make sure to publish source with releases HOT 1
No reason for setDispatcher(), setHistoryFilter() to be public HOT 1
Getting to the flow instance from the dispatcher can be awkward HOT 2
The purpose of MultiKey HOT 2
Change log says "alpha2" even for "alpha3" HOT 1
`Flow.get(context)` returns null during `Activity.onCreate` HOT 1
State not reloaded HOT 2
Make it clearer which end of the Flow history stack is the top HOT 2
Crash while cleaning up a transition that finished after Activity.onDestroy HOT 1
Save view state with id = -1
[Question] Future of Flow HOT 3
Do not reload rest api when go back HOT 1
ETA for 1.0? HOT 4
help :
Recipe for creating nested screens with Flow? HOT 1
Is this project abandoned? HOT 4
InternalLifecycleIntegration memory leak on P emulator HOT 1
How to get result from previous Screen? HOT 2

New way to break Flow.goBack() about flow HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pendingTraversal = next;

	if (pendingTraversal == null) {
	final Iterator<Object> it = tearDownKeys.iterator();
	while (it.hasNext()) {
	keyManager.tearDown(it.next());
	it.remove();
	}
	keyManager.clearStatesExcept(history.asList());
	} else if (dispatcher != null) {
	pendingTraversal.execute();