Git Product home page Git Product logo

Comments (8)

almozavr avatar almozavr commented on August 10, 2024

↑ Here is an example of solving issue for rotation only situation (when backstack stays the same instance).

from flow.

almozavr avatar almozavr commented on August 10, 2024

Please, could someone tell me why ActivityFlowSupport#getBackstackToSave(Backstack backstack) creates a copy of backstack with dropped viewstates? This is key to problem of overall persistance (e.g. activity was destroyed and user goes back to app again)

from flow.

almozavr avatar almozavr commented on August 10, 2024

↑ Fix for graceful backstack's viewstates persistance. Don't know if it's dirty for current code model, so punish hard, ready to take it further

from flow.

rjrjr avatar rjrjr commented on August 10, 2024

PTAL at https://github.com/square/flow/pull/72/files

from flow.

almozavr avatar almozavr commented on August 10, 2024

@rjrjr Sorry, I found no solution of this problem in #72, because:

  • ActivityFlowSupport#getBackstackToSave still ignores current viewstates of backstack entries;
  • flow support doesn't do snapshot of viewstate of current path before getBackstackToSave called, so I suppose e.g. EditText text will still be lost on rotation.

from flow.

rjrjr avatar rjrjr commented on August 10, 2024

Yup, rotation is definitely broken. Still not sure that this is the way to fix it though, looking.

from flow.

loganj avatar loganj commented on August 10, 2024

Yep. Thanks for the catch, and for the patches. I've made some slightly different fixes in #75.

from flow.

almozavr avatar almozavr commented on August 10, 2024

Thanks, looks great.

On Fri, Apr 3, 2015 at 12:24 AM Logan Johnson [email protected]
wrote:

Closed #67 #67.


Reply to this email directly or view it on GitHub
#67 (comment).

from flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.