Error thrown parsing fairly long (but valid) postgresql statement about sql-formatter HOT 3 CLOSED

Thanks for reporting. The problem is with the keyword VALUES. The same problem happens in this shorter SQL query:

SELECT values.id FROM my_table AS "values"

The formatter expects values to be the beginning of a VALUES (...) clause, but here it's used as a table name.

Currently the workaround is to simply quote it.

It's likely something that isn't easy to fix, because it stems from the architectural problems in the formatter.

As you're using PostgreSQL, I can suggest you instead try prettier-plugin-sql-cst, which formats this query just fine. It doesn't yet have full PostgreSQL support, but if you're mainly formatting queries, it should work better than SQL Formatter.

from sql-formatter.

Ah, that makes sense.

It's probably best practice not to use keywords as table names so I think I'll just change the name of that cte :)

from sql-formatter.

I'll close this issue as it's too unlikely that it'll get fixed.

from sql-formatter.