Comments (2)
More correctly, the code will enter an infinite loop, because you have defined a parameter to be an empty string, and there are infinitely many empty strings in any string. So the formatter will correctly detect infinite amount of these custom parameters.
The formatter could possibly check whether the supplied regex is an empty string, and throw a more friendly error message instead of getting stuck in infinite loop. If you're really interested in getting a better error in this specific case, I'm open to a pull request.
However there are infinitely many regexes that would end up matching empty string (for example (|)
) and therefore triggering an infinite loop. It's not really feasible to properly validate them all.
from sql-formatter.
Oh well. As I'm already looking into this code, might as well add this little extra check.
from sql-formatter.
Related Issues (20)
- [FORMATTING] Will not format #Temp Tables HOT 1
- Error when formatting Spark SQL HOT 2
- [FORMATTING] TransactSQL incorrectly formats some block comments, leading to broken statements HOT 2
- Plugin for IntelliJ HOT 1
- Feature Request: Keep some blank lines when formatting HOT 1
- [FORMATTING] Error when formatting Clickhouse SQL with Array column type HOT 1
- Feature Request: expose parsing apis HOT 3
- [VSCODE] `SQL-Formatter-VSCode.expressionWidth` not respected HOT 2
- "Prettier-SQL.tabulateAlias": true ignores back ticks HOT 1
- [FORMATTING] MariaDB function call parenthesis spacing results in invalid MariaDB SQL HOT 5
- [VSCODE] Inconsistent formatting between VSCode extension and CLI HOT 2
- [VSCode] Feature Request: Support JSON config file HOT 1
- [FORMATTING] Missing space after colon in `JSON_OBJECT(key: value)` HOT 1
- [FORMATTING] BigQuery: Doesn't handle escaped quotes in raw strings HOT 1
- Feature Request: Double colon support HOT 1
- Feature Request: Detect dialect inside a comment or filename
- [FORMATTING] problem with line like 'ORDER BY t1.DATE DESC, t1.[%title%] ASC' HOT 8
- Feature Request: Detect / Format parameters included in SQL statement HOT 2
- [FORMATTING] Quotation marks incomplete, formatting error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sql-formatter.