Git Product home page Git Product logo

Comments (2)

ukupat avatar ukupat commented on July 22, 2024

Hey, @PhiseySt! Thanks for your report 👍

As I can see the formatter has two issues:

  1. $ is identified as an operator – We introduced specialWordChars configuration in c4c1da2 which could help us resolve this issue.
  2. Our regex does not identify cyrillic letters as part of a word – That was a huge surprise for me. Read more https://stackoverflow.com/a/18471465. Hint: Tokenizer class has a function createWordRegex.

I would be very grateful if you could play around with the source code, try to fix the issues and make a PR.

from sql-formatter.

PhiseySt avatar PhiseySt commented on July 22, 2024

Thanks for hints!
For the solution of problems I was helped by changes in the sql-formatter.js file:

  1. StandardSqlFormatter.prototype.format = function format(query) {
    if (!tokenizer) {
    ...
    lineCommentTypes: ["--"],
    specialWordChars: ["$"]

    });
    }
    return new _Formatter2["default"](this.cfg, tokenizer).format(query);
    };
    return StandardSqlFormatter;

  2. Tokenizer.prototype.createWordRegex = function createWordRegex() {
    var specialChars = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : [];

       return new RegExp("^([\\wа-яА-Я" + specialChars.join("") + "]+)");
    

    };

from sql-formatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.