Comments (2)
Hey, @PhiseySt! Thanks for your report 👍
As I can see the formatter has two issues:
- $ is identified as an operator – We introduced specialWordChars configuration in c4c1da2 which could help us resolve this issue.
- Our regex does not identify cyrillic letters as part of a word – That was a huge surprise for me. Read more https://stackoverflow.com/a/18471465. Hint: Tokenizer class has a function createWordRegex.
I would be very grateful if you could play around with the source code, try to fix the issues and make a PR.
from sql-formatter.
Thanks for hints!
For the solution of problems I was helped by changes in the sql-formatter.js file:
-
StandardSqlFormatter.prototype.format = function format(query) {
if (!tokenizer) {
...
lineCommentTypes: ["--"],
specialWordChars: ["$"]
});
}
return new _Formatter2["default"](this.cfg, tokenizer).format(query);
};
return StandardSqlFormatter; -
Tokenizer.prototype.createWordRegex = function createWordRegex() {
var specialChars = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : [];return new RegExp("^([\\wа-яА-Я" + specialChars.join("") + "]+)");
};
from sql-formatter.
Related Issues (20)
- Canot format document when '#' character is Found HOT 1
- Snowflake Unable to format SQL: Error: Parse error: Unexpected "@test;" at line 7 column 6 HOT 2
- Formatting Error with Temporary Functions HOT 2
- [FORMATTING] column name "match" is converted to uppercase. HOT 3
- [FORMATTING] Oracle pl/sql, assignment in case block HOT 1
- [FORMATTING] array type HOT 1
- [FORMATTING] Issue Title Here HOT 1
- [FORMATTING] Formatter doesn't like the ~ in SQL statement HOT 1
- [FORMATTING] Will not format #Temp Tables HOT 1
- Error when formatting Spark SQL HOT 2
- [FORMATTING] TransactSQL incorrectly formats some block comments, leading to broken statements HOT 2
- Plugin for IntelliJ HOT 1
- Feature Request: Keep some blank lines when formatting HOT 1
- [FORMATTING] Error when formatting Clickhouse SQL with Array column type HOT 1
- Feature Request: expose parsing apis HOT 3
- Supplying empty regex crashes browser HOT 2
- [VSCODE] `SQL-Formatter-VSCode.expressionWidth` not respected HOT 2
- "Prettier-SQL.tabulateAlias": true ignores back ticks HOT 1
- [FORMATTING] MariaDB function call parenthesis spacing results in invalid MariaDB SQL HOT 5
- [VSCODE] Inconsistent formatting between VSCode extension and CLI HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sql-formatter.