spring-petclinic / spring-petclinic-angular Goto Github PK

Specialties page not implemented

asdasd

Upgrade from Angular 6 to Angular 8

I would like to make some enhancements to the Angular project, mainly I would like to update the following:

• add icons for all nav tabs
• center the content inside the "welcome" component
• make the footer fixed at the bottom of the page. This will improve the look of the website when the user is switching between different nab tabs. The footer will no longer jump up and down when the data for the tables is being fetched.
• add some padding-left to the navbar brand
• only show the "Home" and "Add" buttons on the list components after the data from the backend has been received. This will ensure that the "Home" and "Add" buttons will be displayed at their final position on the page, instead of jumping down after the table data has been fetched.

2 tests:
OwnerListComponent should call ngOnInit() method
OwnerListComponent should show full name after getOwners observable (async)
not work

Pet types page not implemented

By the way, we may rename this repo to spring-petclinic-angular and spring-petclinic-angular1 to spring-petclinic-angularjs

With the last Angular CLI 6.1.5, the ng serve is failing:

Local workspace file ('angular.json') could not be found.

The migration to Angular CLI 6 and Angular 6 has some impact:

• New angular.js configuration file
• RxJS 6 breaking changes: https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#breaking-changes-7
• Migration from HttpModule (deprecated) to HttpClientModule

I began to work on this upgrade. You may check the feature/angular6 branch: https://github.com/arey/spring-petclinic-angular2/tree/feature/angular6

For validation purpose and a better user experience, I think it could be interesting to add a datepicker.
I've tried to integrate this one: https://github.com/ng2-ui/datetime-picker but I failed.

The PR spring-petclinic/spring-petclinic-rest#52 introduce some changes to the backend API:

• date format have changed to RFC-3339
• some bidirectional ids have been removed.
• search by lastname API has changed
• The /pets resource move to /owners/{ownerId}/pets

Thoses changes may be reported to the Angular frontend.

I am unable to successfully clone and checkout this repo. Here's what I'm seeing:

λ git clone https://github.com/spring-petclinic/spring-petclinic-angular.git
Cloning into 'spring-petclinic-angular'...
remote: Enumerating objects: 1025, done.
Receiving objects: 9remote: Total 1025 (delta 0), reused 0 (delta 0), pack-reused 10255% (974/1025)
Receiving objects: 100% (1025/1025), 838.67 KiB | 2.60 MiB/s, done.
Resolving deltas: 100% (758/758), done.
error: unable to create file [email protected]:: Invalid argument
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

Git status shows a whole lot of deleted files and a handful of untracked ones. If I retry the checkout, I get the following:

λ git checkout -f HEAD
error: unable to create file [email protected]:: Invalid argument
Your branch is up to date with 'origin/master'.

I followed the steps and after running "http://localhost:4200/", I got the error "Cannot GET /" with status "404 Not Found".
After I changed to angular-cli with version 8.0.3, the project run as expected.

Detailed error message:

Error: undefined:9274:12: @keyframes missing name

assets/less/petclinic.less - Error: assets/less/petclinic.less from Css Minimizer 
/home/projects/spring-petclinic-angular/assets/less/petclinic.less:162:37: Unknown word
You tried to parse Less with the standard CSS parser; try again with the postcss-less parser [assets/less/petclinic.less:162,37]
You tried to parse Less with the standard CSS parser; try again with the postcss-less parser
    at Input.error (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/input.js:123:16)
    at Parser.unknownWord (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/parser.js:518:22)
    at Parser.other (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/parser.js:149:12)
    at Parser.parse (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/parser.js:59:16)
    at parse (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/parse.js:11:12)
    at new LazyResult (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/lazy-result.js:133:16)
    at Processor.process (/home/projects/spring-petclinic-angular/node_modules/postcss/lib/processor.js:36:12)
    at cssnanoMinify (/home/projects/spring-petclinic-angular/node_modules/css-minimizer-webpack-plugin/dist/utils.js:58:61)
    at minify (/home/projects/spring-petclinic-angular/node_modules/css-minimizer-webpack-plugin/dist/minify.js:15:32)
    at /home/projects/spring-petclinic-angular/node_modules/css-minimizer-webpack-plugin/dist/index.js:262:128

An Angular version and a React version of Spring Petclinic exist. We are looking some contributors to develop a Vue.js version. Please let me know.

Incorect navbar display with latest bootstrap version (4.0.0-alpha.6)

I am looking to contribute to develop a primefaces version of spring-petclinic. Let me know your views on this.

Veterinarians edit/add/delete not implemented

Getting this error on start
Parameter 1 of constructor in org.springframework.samples.petclinic.rest.OwnerRestController required a bean of type 'org.springframework.samples.petclinic.mapper.OwnerMapper' that could not be found.

In the root folder, after a git cloneand a npm install the command ng build triggers the following error:

You have to be inside an angular-cli project in order to use the build command.

Here are my angular-cli informations:

angular-cli: 1.0.0-beta.28.3
node: 7.5.0
os: darwin x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-beta.32.3
@angular/compiler-cli: 2.4.8

Can any body let me know why the exceptions or Sucess messages from angular4 are not disaplyed from the Spring Boot back end. For example simple validations are not displaying the validations messages on the UI.

I have a problem when creating the bundle for it to be deployed on a HTTP server.

The index.html page is located at: http://localhost:63342/spring-petclinic-angular/dist/index.html
The request to all js files is sent relative to this url setting the base href to ./
The request to the images files is sent to
http://localhost:63342/assets/images/angular.png

Notice the relative path is not used.

To make the bundle I am using the following commands:
ng build --prod --base-href=./ --deploy-url=./

TSLint has been deprecated since 2019.
See a migration guide : https://blog.ninja-squad.com/2021/03/31/migrating-from-tslint-to-eslint/

See comment posted by @simrin051 in #74 (comment)_

Need add search options (owner by name etc...)

Notification sent by GitHub:

Known moderate severity security vulnerability detected in handlebars < 4.0.0defined in package-lock.json.package-lock.json update suggested: handlebars ~> 4.0.0.Always verify the validity and compatibility of suggestions with your codebase. | Known moderate severity security vulnerability detected in handlebars < 4.0.0defined in package-lock.json. | package-lock.json update suggested: handlebars ~> 4.0.0. | Always verify the validity and compatibility of suggestions with your codebase.
Known moderate severity security vulnerability detected in handlebars < 4.0.0defined in package-lock.json.
package-lock.json update suggested: handlebars ~> 4.0.0.
Always verify the validity and compatibility of suggestions with your codebase.

Review vulnerable dependencies

Form data validation not implemented

Upgrade from Angular 8 to Angular 11
Feel free to work on this enhancement then submit a Pull Request.

f:\Java\projects\learning\spring-petclinic-angular>npm ls typescript [email protected] f:\Java\projects\learning\spring-petclinic-angular +-- @angular/[email protected] -> f:\Java\projects\learning\spring-petclinic-angular\node_modules\_@[email protected]@@angular\cli | +-- @ngtools/[email protected] | | -- [email protected] extraneous
| -- [email protected] -- [email protected] -> f:\Java\projects\learning\spring-petclinic-angular\node_modules_typescript@2.3.3@typescript extraneous

npm ERR! extraneous: [email protected] f:\Java\projects\learning\spring-petclinic-angular\node_modules\typescript
npm ERR! extraneous: [email protected] f:\Java\projects\learning\spring-petclinic-angular\node_modules@ngtools\webpack\node_modules\typescript`

我需要把package.json里的dependencies的"typescript": "^2.2.2"改成"typescript": "~2.2.2"才可以