spring-guides / gs-messaging-jms Goto Github PK

ActiveMQ 5.8.0 changed the artifacts. spring-projects/spring-boot#717 was submitted to upgrade this in Boot. When that is merged, this guide can be updated.

Hi We are facing the following error.

The guide has switched to Artemis but all the references in the README points to ActiveMQ.

An easy place to get started with contributing to Spring is keeping the Spring Boot version up-to-date, so I'm adding this issue as an invitation to first-time contributors.

You need to set the Spring Boot version in:

• initial/build.gradle
• initial/pom.xml
• complete/build.gradle
• complete/pom.xml

Then run test/run.sh to validate the upgrade worked as expected.

see https://stackoverflow.com/questions/45796021/how-does-spring-look-for-enablejms-methods-if-i-dont-have-class-marked-enable

The file test/run.sh is no longer required. This file and the test directory can be deleted.

The file was originally used for Jenkins CI. Now that this project has been converted to GitHub Actions, this file can be removed.

Readme says:

That’s why we recommend that you use a listener container such as DefaultMessageListenerContainer with a cache-based connection factory

This statement is fulfilled by AbstractJmsListenerContainerFactory#createListenerContainer - on debug I see CachingConnectionFactory is passed in line 190.

On the other hand, javadoc https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/jms/listener/DefaultMessageListenerContainer.html says:

Note: Don't use Spring's CachingConnectionFactory in combination with dynamic scaling. Ideally, don't use it with a message listener container at all, since it is generally preferable to let the listener container itself handle appropriate caching within its lifecycle. Also, stopping and restarting a listener container will only work with an independent, locally cached Connection - not with an externally cached one.

I'm confused: Should CachingConnectionFactory be used or not?

I clicked on "Build with Maven", but nothing happened, no text appeared. The same goes for other "Build with" sections.

I copy a class named Receiver2 from class Receiver, but the two listeners was triggered only one of them.

How to achieve broadcast by multiple JMS listeners with the same destination?

I had try invokeDefaultJmsListenerContainerFactory#setConcurrency with argument '2' but it does not work.

Adding DAO component as dependency breaks Jms service and the process starts and ends almost immediately.
To reproduce:
have a working Jms service and try to add DAO dependency with @componentscan("dao.package")

As per the tutorial page of from https://spring.io/guides/gs/messaging-jms/#scratch, I find it not updated with this readme.adoc file.

I built the project by the Spring Initializer on VS Code and I had to check this github repo code for the differences because after all the steps I followed the app had not worked. I believe the dependecies artemis-jakarta-server and spring-boot-starter-json should be clearly stated in the tutorial.

On the getting started page, All include directives give this text
Unresolved directive in - include::complete/src/main/java/hello/Receiver.java[]

Once the guide is followed, there is still an Email class missing.

It mostly duplicates what's in the "Build an executable JAR" section that's just before.

Perhaps it needs to include jackson databind in the maven

After including this library the error changes to
jakarta.jms.JMSException: Failed to create session factory

Perhaps it needs a JMS broker running. However the guide does not provide any instructions. It would be better if it could provide steps like it was provided for messaging with RabbitMq and Redis

When using a JmsTemplate, it is a best practice to use a CachingConnectionFactory. This guide leaves that out. There currently is no Bootiful way to create one, but I created this issue requesting it: spring-projects/spring-boot#13065

The anchor link at https://raw.githubusercontent.com/spring-guides/getting-started-macros/master/how_to_complete_this_guide.adoc (or rather https://spring.io/guides/gs/messaging-jms) with the description
"To start from scratch, move on to Build with Gradle."

points to the anchor "#scratch". This anchor does not exist in this document.

I don't know why, but on my computer the code works only when container.setPubSubDomain; is set to false and not true like the code.
It's a bug ?