spotlightkid / cookiecutter-dpf-effect Goto Github PK

Hi, I suggest that the template default should follow the best practice regarding the license field.
The value "MIT" is invalid, considering that doap:license takes a URI value.

MIT is found at http://opensource.org/licenses/MIT, with opensource.org being a frequently used prefix in LV2.

Also valid is SPDX http://spdx.org/licenses/MIT which has a much more extensive list of licenses, as seen used in doap examples.

It's another minor thing I noticed, this intermediate build directory is not listed in the default file.

Just copy the VST2 stuff and adapt make variables and installation paths.

(Sorry, I'm being pedantic here :))

The 'cookiecutter-dpf-effect' project is licensed under the MIT license. If I use this template to generate a plugin, do I need to 'give appropriate credit, provide a link to the license, and indicate if changes were made' in my project?

I'm particularly confused when it comes to the Makefiles, which are based on the DISTRHO plugins. I think it is safe to say that these files were originally ISC-licensed. Are the Makefiles in 'cookiecutter-dpf-effect' actually dual-licensed ISC + MIT?

See: https://github.com/SpotlightKid/cookiecutter-dpf-effect/pull/2/files#r308602806

Dealing with makefiles is hard, most people dont want to do it for good reasons.
I made changes in DPF so that plugins that want to make use of its makefiles can now do so.
This way anything that needs to be fixed in those makefiles can be made directly by me, and not having to bother all 3rd party devs to update their initial copy of the makefiles created when forking over plugin-examples or from this generator.
See https://github.com/DISTRHO/plugin-examples for the new stuff.
I plan to go through all my plugins and update them to this new style.
Also the zam-audio plugins.

Note that adding extra build deps and link flags still remains possible.
Let me know if you need those, and I will explain the details.

make submodules (defined here) will fail if submodules have not yet been cloned, which kinda defeats the purpose of this rule...

$ make submodules
Makefile:7: dpf/Makefile.base.mk: No such file or directory
make: *** No rule to make target 'dpf/Makefile.base.mk'.  Stop.

Should we get rid of this rule? Otherwise, we could handle the "missing dpf/Makefile.base.mk" error more gracefully, and print an error message when submodules are missing:

DPF not found. Please run "make submodules" to clone the missing submodules, then retry building the plugin.

Hi. In the rules install and install-user, the variable checked is at one point HAVE_JACK, and then BUILD_JACK somewhere else.

It's at these locations:

In continous build configuration with Ubuntu Trusty, I have this problem,
When running make install as the root user, there are messages like this:

# install -D -m755 bin/stone-phaser-vst.so -t /usr/local/lib/vst
install: failed to access '/usr/local/lib/vst': No such file or directory

it's because regardless of the -D flag presence, this OS cannot install if the directory does not exist. (which seems to contradict the man page, but that's what it is)
When the directory is created first using install -d, then it's fine.

Hello,

The initialization of plugins is filling the parameter values with the preset 0, I don't think that's right.
Most probably, it's going to put the state in disagreement with the host's parameters, and the potential UI. (unless the host will init parameters or select program)

At least in DPF internally, the editor is not initialized automatically on the program 0.

Probably, it's preferable to initialize with ranges.def.
This is a little more awkward to write this way; an example about what I mean. https://git.io/JvUNT

Hi, the LV2 install should use $(LIB_EXT) not .so. See this report
linuxmao-org/regrader-port#2

Hello, FreeBSD has been reported to fail at the make install step.
The command install does not have identical meaning as GNU for -d,-D options.

A workaround is to replace install with mkdir where applicable.
This patch has been reported as working.
linuxmao-org/fogpad-port#3