Please update the composer.json to support php 7.4

https://github.com/SpotlerSoftware/magento2-mailplus-connector/blame/c314b5759a5917f700a5fd0b3d9dfb1102062ed0/Observer/CreateCartObserver.php#L47C3-L48

We can probably move the save into the if block.

These are years old and will probably not work, but these shouldn't be in here:
https://github.com/SpotlerSoftware/magento2-mailplus-connector/blame/c314b5759a5917f700a5fd0b3d9dfb1102062ed0/auth.json#L3

The version in composer.json is incorrect thus this tag is skipped. Hence, I can't install the module on PHP 7.3.x.

From composer:

Reading composer.json of mailplus/mailplus-connector (v1.7.0)
Reading /composer/cache/repo/github.com/SpotlerSoftware/magento2-mailplus-connector/160a7b7b840bc118e9a8f01503ca0e883345ee15 from cache
Skipped tag v1.7.0, tag (1.7.0.0) does not match version (1.6.0.0) in composer.json

Hello,

The last magento upgrade was just released but unfortunately the extension is currently not compatible with it. Are you already working on a fix?

We have magento Enterprise 2.1.10
We will create a customization that will allow creating subscription per website.
Example : Store_id = 1 email=[email protected] ; store_id = 2 email=[email protected]. System will create subscription per website.
Will your module support this customization correctly?

Magento fails to complete setup:upgrade with the following error:

Running schema recurring...Invalid XML in file ..../vendor/mailplus/mailplus-connector/etc/acl.xml:
Element 'acl': Missing child element(s). Expected is ( resources ).
Line: 4

This is because Magento 2.2+ enforces the xml schema and expects one or more acl rules to be declared, while the acl.xml file is empty. This occurs for me in an installation I just upgraded from 2.1, I'm not entirely clear on why it doesn't occur on a fresh Magento 2.2 installation. It's probably turned off for new installations.

Removing the acl.xml file since it's doesn't do anything anyway fixes the issue.

Or define ACLs :-)

Update: after some plodding around I've found that the error doesn't occur in a fresh installation because M2 then runs in default deployment mode. M2 validates the xml schema only when running in developer mode.

The module seems to be missing support for databases that use a DB prefix. Upon installing the module the database tables are created, but are missing the prefix.

Example:

• Prefix: magento_
• php bin/magento setup:upgrade
• Tables created: mp_catalog_rule_updated_at / mp_quote_conversion
• Missing prefix magento_

Magento 2.2.4

The issue only became apparent for us in Magento 2.2.4 since Magento's core fix for magento/magento2#8035 was included. This in turn fixed the module's use of extension_attributes.xml. Resulting in errors while sending transaction emails:

Base table or view not found: 1146 Table 'my_db.magento_mp_quote_conversion' doesn't exist

Temporary fix

I fixed this by commenting the corresponding lines in extension_attributes.xml, but of course this hinders some of the module's functionality.

Hello,

I've got this error while execution of native Magento 2 "sales_clean_quotes" cron job on [Magento 2.1.7]:

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`project_db`.`mp_quote_conversion`, CONSTRAINT `conversion_quote` FOREIGN KEY (`quote_id`) REFERENCES `quote` (`entity_id`) ON DELETE NO ACTION), query was: DELETE FROM `quote` WHERE (entity_id='2500')

Cron job "sales_clean_quotes" details:

<job name="sales_clean_quotes" instance="Magento\Sales\Cron\CleanExpiredQuotes" method="execute">
    <schedule>0 0 * * *</schedule>
</job>

Current job collects all inactive quotes that are older than the configured lifetime - and delete them. But after installation of MailPlus extension, Magento can't delete expired quotes due to the constraint that was built in \MailPlus\MailPlus\Setup\UpgradeSchema::upgrade .

As I can see from MailPlus extension logic, there is a need to disable quotes clean-up cron job "sales_clean_quotes", because MailPlus extension requires to have all quotes available in DB to provide full information about conversion.

Please check this issue, as tmp solution I will disable "sales_clean_quotes" cron job on mine project.
Thank you.

Could you indicate when this module will be updated to be compatible with Magento 2.2.0?

Regards,
Vincent

Hi,
we are using the Magento Commerce with split databases. In a split DB setup the sales (orders), quotes and catalog are split up.

We noticed a non working foreign key on the mp_quote_conversion table. The conversion_quote FK references the quote table which is in another database (quote DB) and does not work with split databases.

A problem might also occur with the extension attributes from quote and sales to the quote_conversion table.

Could you tell us if this is a known issue and if it's going to be fixed?

I've opened two pull requests #24 and #25. Any idea when these can be merged?

Because of the CartItem extension attribute product_id in this module, the quoteToOrder converter is missing the productId. This leads to potential errors, which we found out by combining with Anowave/Ec module. We found the order items to no longer have productId's. We've managed to track this to this di:
<extension_attributes for="Magento\Quote\Api\Data\CartItemInterface"> <attribute code="product_id" type="string"> </attribute> </extension_attributes>

This only happens in Magento 2.3.3, this does not happen in Magento 2.3.2.

Could you please add this package to https://packagist.org/ ?
This would make the installation process a lot faster than through VCS.

We've recently upgraded the module to version 1.8.1 from 1.7.4 and we've noticed that since this version the module is inputting values in the table 'mp_catalog_rule_updated_at' and since in the UpgradeSchema you are creating a foreign key relation for which you have not set the 'onDelete' action for this, when trying to delete a cart price rule you get an error saying you cannot delete the rule.
The error generated is as follows (xdebug):
SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (magento.mp_catalog_rule_updated_at, CONSTRAINT catalogrule FOREIGN KEY (catalog_rule_id) REFERENCES catalogrule (rule_id)), query was: DELETE FROM catalogrule WHERE (rule_id = '1')

Please look into this and resolve the issue in a next version.

I'm missing a license in this module as a LICENSE.md file. It is mentioned in the composer.json, but I would advocate for seperate md file for this as well.

I see that in the response from this api:
{baseurl}rest/V1/mailplus/subscribers?searchCriteria[filter_groups][0][filters][0][field]=subscriber_email&searchCriteria[filter_groups][0][filters][0][value]={emailvalue}

the gender is missing. Also in the service contracts is missing. See: MailPlus\MailPlus\Api\Data\SubscriberInterface
Is there a reason why?
Otherwise , how can i know if a subscriber is a male, female or the gender is missing ?

I am running version 1.6.0 of the module on Magento 2.3.5

Thank you and looking forward hearing from you!

Currently the mpId on an order can only be set via cookies at the moment a cart is being created.
This causes trouble if your frontend is running on another (sub)domain for e.g. headless frontends.

Setting a cookie in this frontend has no effect on the backend, and trying to pass this cookie with e.g. https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials is a security concern and violates CORS in most cases.

My suggestion is adding a REST or Graphql endpoint requiring the cart id and mpId, to be able to set this id on the cart even if your backend and frontend are not on the same cookie domain.