Git Product home page Git Product logo

Comments (5)

diegoaldarondo avatar diegoaldarondo commented on July 17, 2024

Committing soon to the refactor_imports branch with fully linted code. We should consider merging to master if you're ok with the file structure.

from dannce.

spoonsso avatar spoonsso commented on July 17, 2024

Awesome, looks good. See the few comments I left.

from dannce.

spoonsso avatar spoonsso commented on July 17, 2024

can we verify that run_undistort_opencv.py and undistort_COMS.m can be safely deleted? These files were initialize designed to deal with cases where the COMfinder net would crash without finalizing COM undistortion, because pre-opencv the undistortion was happening over all of save_data at the end of the script. Now that we are undistorting on the fly, the predict_COMfinder.py checkpoint behavior should be just to save the pickle file itself whenver there is a checkpoint. @ksseverson57

from dannce.

spoonsso avatar spoonsso commented on July 17, 2024

Deleted these files and refactored COM checkpoints to not have to use any intermediaries

from dannce.

spoonsso avatar spoonsso commented on July 17, 2024

Most of the dead code is now gone in v1.0.0. Although there may still be unused functions in ops.py and processing.py. However, these may be useful for future users.

from dannce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.