spoo-bar / cosmy-wasmy Goto Github PK

Describe the bug
After v2.2.0 is upgraded, it cannot be load on mac. But it's no problem when rollback to v2.1.0.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows]
• Version [e.g. 1.68.0]
• Running vscode Insider [e.g yes/no]

Additional context
Add any other context about the problem here.

When a contract is imported, store it in relation to the current chain config.
And do not display the contracts when other chain config is active

Good Job,
Thanks for making this extension.

I try it out for this increment contract:
https://github.com/archway-network/archway-templates/tree/main/increment

Query, Execute contract works fine but the Initialize operation doesn't work. It throw this error message:

Executing the command directly works fine:

junod tx wasm instantiate 1 '{"count": 100}' --from testAccount --label "Our third contract" --no-admin

Perhaps there is a problem with parsing the JSON?

Is your feature request related to a problem? Please describe.

Hello, I'm a mainnet core developer at Finschia. I would like to support Finschia with Cosmy Wasmy.
Finschia aims to become the world’s No. 1 blockchain ecosystem, leading the popularization of Web3 and securing over 1 billion users.

Home page - https://www.finschia.io
Github - https://github.com/Finschia/finschia

Describe the solution you'd like

• Add Finschia testnet config
• Support cointype config because coin type of Finschia is 438 not 118

Describe alternatives you've considered

Additional context

Allow the Simulate view to register multiple code ids for simulating contract interactions

Chain registry - https://github.com/cosmos/chain-registry
Schema - https://github.com/cosmos/chain-registry/blob/master/chain.schema.json

Describe the bug
I have testing on okc testnet.After i upgrading v2.0.0, i can't see my amount of acount.
v1.2.0:

v2.0.0

To Reproduce
Steps to reproduce the behavior:
1 run okc localnet on macos

git clone https://github.com/okx/exchain.git
cd exchain/dev/
./start.sh

2 config the chain config of cosmy-wasmy

{
            "configName": "local okc with okt",
            "chainId": "exchain-67",
            "chainEnvironment": "localnet",
            "addressPrefix": "ex",
            "rpcEndpoint": "http://localhost:26657",
            "defaultGasPrice": "0.0000000001",
            "chainDenom": "okt"
},

3 create a random account X in comsy-wasmy , e.g: ex1kyh26rw89f8a4ym4p49g5z59mcj0xs4j9xcvw3

4 transfer okt to the account X on localnet

exchaincli tx send ex1h0j8x0v9hs4eq6ppgamemfyu4vuvp2sl0q9p3v X(replace your account) 10okt --from captain --gas auto  --gas-prices 0.0000000001okt --gas-adjustment 1.3 -y -b block

5 switch the version between 1.2.0 and 2.0.0, and restart vscode

Expected behavior
See the acount amount on version v2.0.0

Screenshots

Desktop (please complete the following information):

• OS: [e.g. MacOS]
• Version [e.g. 12.6.2]
• Running vscode Insider [e.g no]

Additional context
Add any other context about the problem here.

VSCode by default uses ctrl+shift+h to Replace in files & the most recent version overwrites that
https://github.com/spoo-bar/cosmy-wasmy/blob/main/package.json#L268-L270

Replace in Files | Ctrl+Shift+H | workbench.action.replaceInFiles
https://code.visualstudio.com/docs/getstarted/keybindings

While a fix is to put { "key": "ctrl+shift+h", "command": "workbench.action.replaceInFiles"} in keybinds.json (per user basis), it likely makes more sense to try and use another keybind to not cause this issue for others

When connected to a localnet, import all contracts deployed on chain in a single click.

Maybe allow this for testnet and mainnet as well with a secondary confirmation from the user.

I found that the tx fee is 1 native token by default, how can I use custom tx fee?

Is your feature request related to a problem? Please describe.
When contract execution requires funds, cosmy wasmy can't add funds to the execution.

Describe the solution you'd like
Take this contract for example, it sends stargate msg to osmosis' tokenfactory to create denom, and it requires creation fee.

It would be nice if we can add ##funds as an addition input for contract execution, parsed as coins and pass them to the execute function and strip them out before actually sending the msg. (could just extract and strip it here?)

{
  "create_denom": {
    "subdenom": "poopcoin",
    "initial_mint": "10000000000"
  },
  "##funds": [
    "1000000000uosmo"
  ]
}

Happy to contribute if you agree with the approach!

• When only one contract is imported for a given code id - same view as now
• When multiple contracts have been imported for same code id - do 1-level tree view

• Might need to use secret.js

The cosmwasm-vm that is used here is taken from here I guess. Note that this cosmwasm-vm version is outdated, it contains some severe bugs (e.g. admin is incorrectly checked when doing migrate). And the vm implementation is missing some host functions so that if any contract call these, they will likely to be failed or run incorrectly. I would be happy to upgrade the vm implementation that will cover all of the host functions as well as using the most recent cosmwasm-vm.

Add setting to sort contracts by

1. Imported order, or
2. Code ID, or
3. Label text

The cosmwasm-vm implementation used has not properly been attributed according to the license, meaning that currently the plugin cannot be used by developers and companies.

It's quite impolite and illegal, although I assume this was an honest mistake.

Add option to add metadata comments to contract which shows on hover

during contract init, make it configurable to either add the instantiator as admin or init the contract with no admin

Describe the bug
Simulate in Virtual Machine is not working. The simulate view is not being fully rendered due to an error.

To Reproduce
Steps to reproduce the behavior:

1. Open the directory containing the contract in VSCode
2. Make sure there is "Cargo.toml" with the package details at root of directory and the schema is generated in "./schema/.json"
3. Right click on the wasm file and click on "Load in Virtual Machine"
4. See error

Expected behavior
The simulate view should appear allowing to Instantiate, Query and Execute the smart contract within the Virtual Machine.

Screenshots
The error

Desktop (please complete the following information):

• OS: Ubuntu 20.04
• Version: 2.4.0
• Running vscode Insider: no

Additional context
The error seems to come due to a dependency issue (which according to the error is @vscode/webview-ui-toolkit, which was in package.json as a dependency). I tried running npm install in ~/.vscode/extensions/spoorthi.cosmy-wasmy-2.4.0 and tried the virtual machine option again.

This time it seemed to render properly but I was facing a different issue. I was getting "Uncaught TypeError: Cannot read properties of undefined (reading 'data') at wasm-vm.js:56:86". It was in the message event listener. It was getting a response from the extension with command: "instantiate-res" but the value was an empty object. I am guessing the message is being sent from here (cosmy-wasmy/src/views/wasmVmPanel.ts:178). For some reason, line 177 is returning an empty object.

Let me know if you need more details.

All contracts which have been deployed by the selected user, import them all to the extension

• When multiple contracts of the same CodeId are added, the rendering breaks as vscode prevents multiple elements with same id

in the execute view, add an option to simulate the tx instead of executing it

Currently the Load in VM gets the schema from the repository hardcoded path.
Modify it to allow custom path input in the view
Try to enable schema file selection from anywhere in local filesystem

vscode api provides extensions with the capability to store secrets which arent available to other extensions.

Replace current plaintext storing of seedphrasess to using vscode.SecretStorage

Also remove all warnings about the seedphrases post implementation