Git Product home page Git Product logo

Comments (9)

Mumfrey avatar Mumfrey commented on May 25, 2024

Initialisers in mixins have always been ignored. You must inject into the initialiser in the target class in order to call construct-time logic.

from mixin.

zml2008 avatar zml2008 commented on May 25, 2024

Except that when I try that, I get told that injecting is not allowed with multi-target mixins

from mixin.

Mumfrey avatar Mumfrey commented on May 25, 2024

It should be allowed if you set remap=false on the @Inject annotation. The reason it's not allowed on remapped injectors is that a single name in multiple classes which are obfuscated will obviously remap to multiple names in each target class so I can't squeeze it through the obfuscator. But <init> always has the same name and so you can set remap=false on it and it should be fine.

If that doesn't work let me know and I'll check the AP logic.

from mixin.

zml2008 avatar zml2008 commented on May 25, 2024

That sorta works -- now I'm getting an issue with the fact that the different targets take different constructor arguments:

Caused by: org.spongepowered.asm.mixin.injection.InvalidInjectionException: Invalid descriptor on callback: expected (Ljava/io/File;Ljava/net/Proxy;Ljava/io/File;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V but found (Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V
    at org.spongep

(the output was cut off there in the terminal, not mispaste)

from mixin.

Mumfrey avatar Mumfrey commented on May 25, 2024

Hmm. Well if you don't actually need the actual arguments then I could make it so that injectors can be created which don't take the method args in their signature. That should let you inject with impugnity.

from mixin.

zml2008 avatar zml2008 commented on May 25, 2024

yeah, I don't care about the arguments so that sounds like what I'd need.

from mixin.

Mumfrey avatar Mumfrey commented on May 25, 2024

Ok I'll get right on that.

from mixin.

Mumfrey avatar Mumfrey commented on May 25, 2024

Ok, as of the commit above you can now make injector callbacks with only the CallbackInfo argument. You will need to update the mixin library version to 0.4.3 in spongecommon to get this change though.

from mixin.

zml2008 avatar zml2008 commented on May 25, 2024

Great, that seems to work. Thanks!

from mixin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.