Git Product home page Git Product logo

Comments (6)

LlamaLad7 avatar LlamaLad7 commented on June 16, 2024

No, Mixin only parses the classnode if it needs to modify it. You never need to parse the node yourself. Look at fabric's implementation.

from mixin.

0xJoeMama avatar 0xJoeMama commented on June 16, 2024

That doesn't seem to be the case.
Look here:

protected final ClassNode readClass(String className, byte[] basicClass, boolean cacheReader) {

from mixin.

LlamaLad7 avatar LlamaLad7 commented on June 16, 2024

You don't interact with that, you interact with https://github.com/SpongePowered/Mixin/blob/master/src/main/java/org/spongepowered/asm/mixin/transformer/IMixinTransformer.java

from mixin.

0xJoeMama avatar 0xJoeMama commented on June 16, 2024

Yes but I do use IMixinTransformer. However the exposed methods, either take in a ClassNode or take in a byte array, which is then parsed into a ClassNode. Checking the transformClassBytes method in MixinTransformer, leads to a call to transformClass which in turn calls readClass which parses the ClassNode. Unless I am missing something.

public byte[] transformClassBytes(String name, String transformedName, byte[] basicClass) {

public byte[] transformClass(MixinEnvironment environment, String name, byte[] classBytes) {

from mixin.

0xJoeMama avatar 0xJoeMama commented on June 16, 2024

There has been no response on this for a week. Anything new?

from mixin.

Geolykt avatar Geolykt commented on June 16, 2024

I'd not be worried - it is quite usual for issues to go silent in an issue tracker. And you shouldn't really expect a rather fast development cycle for Mixin so it might take a long time till it gets resolved.

from mixin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.