FMLCorePluginContainsFMLMod not supported by MixinTweaker about mixin HOT 13 CLOSED

I'm still getting to grips with FML so apologies for the oversight and thanks for the example. I will incorporate the logic into the mixin tweaker.

from mixin.

FML itself already has the FMLCorePluginContainsFMLMod marker so you can just check for that. Let me know if you need any other assistance.

from mixin.

Ok thanks will do. I'll poke you on IRC if I need any help.

from mixin.

Sure thing, you know where to find me, or just send me a PM and I'll respond when I can.

from mixin.

Hey luacs could you let me know if this solves the issue. I don't actually have an actual mod to test with so I can only assume that since this is based on the code in your tweaker that it works as expected.

from mixin.

I have rebased feature/shade-asm on this commit now, so that version 0.4 on the branch also contains these changes.

from mixin.

Okay. I need to update mixin on my end, and pair this with some classloader changes, so I can only get you a reply Friday at the earliest.

from mixin.

Ok no worries, if there are any changes I'll update them on maven.

from mixin.

On further investigation, I can't get Mixin to run beside only a normal FMLMod without having the ForceLoadAsMod and FMLPluginContains stuff run before the initialization of the FML coremod. I've made a local patch on my side and it seems to work.

Also, how do I get feature/shade-asm to build? It didn't build properly until I added a few lines to build.gradle.

from mixin.

Ah ok, so you're saying that if you move the (current) line 134 to line 160 then it works as expected?

feature/shade-asm should build without problems, although as I mentioned you should use the artefact from my maven repo instead. Make sure your branch is up to date if trying to build it.

from mixin.

Hang on, let me commit what I have so you can take a look. I haven't actually tested it with Sponge or anything else yet.

yuuka-miya@1ed2c2d

from mixin.

Oh I see, well I can change it to that way around and check it still works with sponge and if so I'll apply the change.

from mixin.

Yep, tested and works fine so I've pushed the changes. Just waiting on your feedback on the other branch before I merge it.

from mixin.