Mixin using anonymous class fails with Travis about mixin HOT 7 CLOSED

@bloodmc

/home/travis/build/SpongePowered/Sponge/build/sources/java/org/spongepowered/mod/mixin/entity/vehicle/MixinEntityBoat.java:72: warning: Cannot find method mapping for @at(INVOKE.) 'java.lang.Math.sqrt(D)D
@Inject(method = "onUpdate()V", at = @at(value = "INVOKE", target = "java.lang.Math.sqrt(D)D", ordinal = 0))
^
/home/travis/build/SpongePowered/Sponge/build/sources/java/org/spongepowered/mod/mixin/entity/vehicle/MixinEntityBoat.java:77: warning: Cannot find method mapping for @at(INVOKE.) 'java.lang.Math.sqrt(D)D
@Inject(method = "onUpdate()V", at = @at(value = "INVOKE", target = "java.lang.Math.sqrt(D)D", ordinal = 1))

These two are because remap=false hasn't been set in the @Inject. Only obfuscated classes should be remapped and the jdk isn't obfuscated :p.

from mixin.

@Zidane Yes I saw that, will fix soon.

So I just ran the build locally to see if it would make a difference and it worked. But with Travis, it fails...

from mixin.

I am aware, it seems like an issue which only occurs with travis but I haven't had time to look into it because I've been handling a complicated server migration the last week. I'm back in the real world now so once I've cleared the accumulated backlog I'll have a look.

from mixin.

After speaking with Lex, he recommended that we should support Class ID's that are generated at reobf time. Here is an example

private static final String __OBFID = "CL_00001404";

This might help solve our issue when attempting to use strings for anonymous classes. If it doesn't, it still may be a good feature to support.

from mixin.

I wouldnt bother with those too much. grum tweeted that they have stopped ripping out the inner class table.. so those class IDs shouldnt be needed anymore in the next MC release..

from mixin.

They will still be needed as it's not the inner class names that are the issue, it's the id shifting that happens across the recompile boundary.

from mixin.

@bloodmc I think there's a potentially better way to deal with this anyway, so I'll likely rip out the problem classes. Basically the mirror API doesn't really support anoymous inner classes so this was an attempt to fill the gap. I think I just need to try a different approach.

Using the class IDs doesn't really help because they're not easily available to me at compile time because I only get a somewhat summarised view of the AST via the mirror API.

from mixin.