Git Product home page Git Product logo

Comments (7)

romac avatar romac commented on June 15, 2024

Should be fairly straightforward given that

impl<T, U> Into<U> for T where U: From<T>

and

impl<'a, T> From<Cow<'a, [T]>> for Vec<T> where [T]: ToOwned<Owned=Vec<T>>

from merkle.rs.

romac avatar romac commented on June 15, 2024

Since there are no appropriate From instance for plain u8, I changed the tests to work with values of type Vec<u8> (which is what merkle_signing will use anyway). It works out of the box for Vec<u8> and String.

from merkle.rs.

romac avatar romac commented on June 15, 2024

Now that I think about it, I should have checked what happens with slices (and thus kept that commit in its own branch). Anyway, feel free to re-open if needed.

from merkle.rs.

FredericJacobs avatar FredericJacobs commented on June 15, 2024

LGTM 👍

from merkle.rs.

romac avatar romac commented on June 15, 2024

Just rebased proof on top of that.

from merkle.rs.

FredericJacobs avatar FredericJacobs commented on June 15, 2024

Cool, just don't miss my comment

#1 (review)

from merkle.rs.

romac avatar romac commented on June 15, 2024

I was just reading it :)

from merkle.rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.