Comments (3)
romac
commented on June 15, 2024
1
@afck Thank you for the PR! Just published v1.7.0 to crates.io with your changes :)
from merkle.rs.
romac
commented on June 15, 2024
That would indeed be nice to have, though I wonder if there is indeed a better way to handle proof deserialization without having ProofData. Perhaps by writing manual Serialize/Deserialize instances for Proof, and encoding the Algorithm as eg. a string equals to the name of the corresponding static in ring::digest, ie. SHA1, SHA256, SHA384, SHA512, SHA512_256.
What do you think?
from merkle.rs.
afck
commented on June 15, 2024
Good idea! Supporting the constants in ring::digest should be sufficient for most use-cases. I'll give it a try.
from merkle.rs.
Related Issues (20)
- Enable more flags HOT 3
- Figure out a way to make the fields of Proof and Lemma private again
- Add clippy to Travis build (nightly only) HOT 1
- Contribution guidelines
- No domain separation between leaf and internal node hashes HOT 1
- CT Test Vectors
- Protobuf 1.6.0 broke the build. HOT 5
- Generate proof by index. HOT 1
- Serialize the hash algorithm name in protobuf.
- Protobuf 1.7 broke master again HOT 3
- Consider representing a proof as a vector of ProofBlock instead of a linked-list? HOT 4
- Guard against malformed lemmas. HOT 1
- Add index field to Proof struct
- Fails to build on archlinux with serialization-protobuf HOT 3
- Full code review
- Proof.valdidate doesn't check value
- Design a independent interface but not rely on the `ring` might be better? HOT 1
- Global merkle tree
- Add a way to get/iterate over the values contained in the MerkleTree HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merkle.rs.