SpinalConfig.generate does not work as expected When define two modules with implicit parameter in "generate" func about spinalhdl HOT 7 CLOSED

Hi lycfly,

The first component that is instantiated registers itself as the toplevel component, which is later used e.g. for the name of the module. (it has to so that components inside it can add themselves as subcomponents).
modB in your first example is never really inserted into the internal data model.
I think we should add an error for this corner case.

What's your use-case, what would you like to achieve in the end?

from spinalhdl.

Hi andreasWallner,
Actually I define an SpinalEnum in moduleA and some elements is dynamically added when moduleA is instanced according to the Config. ModuleB will use this dynamically added elements of Enum object so I need to instance moduleA before.
I am just testing whether ModuleB can get this elements, so I write this code in the generate function and find it does not generate the rtl code as I expected.

from spinalhdl.

@lycfly As it is at the moment that doesn't work (for the reason I desribed above) - is it possible for you to move the "common code" outside of ModuleA so that both can call it?

from spinalhdl.

@lycfly As it is at the moment that doesn't work (for the reason I desribed above) - is it possible for you to move the "common code" outside of ModuleA so that both can call it?

Yes, these two modules can be instantiated in an top module.
The code above is for test, and I was just confused about the generate function's behavior.
Thanks for your reply and I will avoid this usage next time.

from spinalhdl.

@Dolu1990 I think it would make sense to generate sat least a warning for the case above, what do you think about that?

from spinalhdl.

Yes, i added a check for it to make an error.
Will give you a "MULTIPLE TOPLEVEL : SpinalHDL only allows a single toplevel Component."

from spinalhdl.

The check can be turned off via the SpinalConfig(singleTopLevel = false)

from spinalhdl.