"stack level too deep" With Database Migration about strongbox HOT 10 CLOSED

Possibly related? SchemaPlus/schema_plus#42

from strongbox.

I'm not seeing this with Rails 3.2.3 and Ruby 1.9.2. What versions are you using? What other gems have you added to your app?

Thanks.

from strongbox.

Rails 3.2.2 / Ruby 1.9.3.

Looks like I have found the problem, I had an initializer that chained ActiveRecord::ConnectionAdapters::Mysql2Adapter#configure_connection to add some additional functionality. Removing that fixes the problem.

Adding this below will reproduce the issue:

if defined?(ActiveRecord::ConnectionAdapters::Mysql2Adapter)
    class ActiveRecord::ConnectionAdapters::Mysql2Adapter
        def configure_connection_with_test()
            configure_connection_without_test()
        end

        alias_method_chain :configure_connection, :test
    end
end

from strongbox.

Hmm, still not able to reproduce this. If you start a clean project with just the above and strongbox, do you get the same error?

from strongbox.

So sorry, forgot to add an important piece of information. The file is included in the config.after_initialize block.

Yes, I was able to reproduce with a clean project.

from strongbox.

I tried 1.9.2/3.2.2 and still can't reproduce it. Can you throw the minimum project that fails for you in a repo?

from strongbox.

Sorry for the delay, here you go: https://github.com/carsonreinke/strongbox-test

from strongbox.

config/initializers/mysql_test.rb is getting loaded twice first automatically by rails the initialization and then explicitly by you in config.after_initialize.

Without Strongbox it works because when Rails loads the initialization file ActiveRecord::ConnectionAdapters::Mysql2Adapter isn't defined, but it is when you load the file.

With Strongbox ActiveRecord::ConnectionAdapters::Mysql2Adapter is loaded when Rails first loads the file. This cause two calls to alias_method_chain which creates the loop.

I assume this happens because Strongbox's call to ActiveRecord::Base.send causes Rails lazy loading to pull in that class sooner.

So, it's not a bug in Strongbox, just a question the gem effecting when the class is loaded. Two way to work with that:

1. Move the initializer code out of the initializers directory so it's only loaded once.
2. Make sure alias_method_chain can only be called once:

unless method_defined? :configure_connection_with_time_zone
  alias_method_chain :configure_connection, :time_zone
end

from strongbox.

Ah, good call. Sorry for the bother.

from strongbox.

No worries, it's a pretty subtle issue.

from strongbox.