Git Product home page Git Product logo

twitch-node-sdk's People

Contributors

fire- avatar fugitech avatar hebo avatar laekh avatar mertzt89 avatar mgp avatar simulatedgreg avatar spiffyk avatar zelgod avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

twitch-node-sdk's Issues

Error when cancelling authentication

When opening the authentication popup and choosing "Cancel" instead of "Authorize" it throws the console error ("Got exception: Uncaught Error: A hash must be specified"). It also redirects the new popup to: https://api.twitch.tv/kraken/ and displays the json response.

Is there a callback to Twitch.login() to avoid this? Or is there any other way around this?

We need a refactor

The Twitch Node.js SDK needs to look much more like a Node module and much less like a web library. The hassle with the Makefile during development is not worth it and is prone to errors. I made a branch named major-refactor to address this.

I want to

  • make a twitch.js file that loads its parts from lib/ as Node modules
  • replace docco comments with yuidoc comments as they frankly make more sense
    • make yuidoc comments exhaustive enough
  • merge some of the Twitch.events methods (on, once etc.) into Twitch for convenience
  • improve overall code readability

npm module is outdated

Was trying to use with Electron but found that the README.md from npm and github don't match, meaning the npm module is outdated. I can build myself, but using npm would be nice too. Kappa

This project needs a new maintainer!

Hello, I'm terribly sorry for not responding to issues lately. As I got to the university, I no longer have much time to maintain this project and I have also lost interest in it. I have also never anticipated that this project would be of any use for anyone but I have been proven wrong. I would hereby like to offer handing the project over to a new maintainer or to create an organization of maintainers to manage the project. Which one would be better, I don't know so I'm asking you guys.

Whether you are willing to take on the project or if you think creating an organization is a better idea, please express yourself in the comments here!

Disable console output

Would anyone be against adding the ability to disable console output? It seems it would be a quick implementation.

Not working with NW.js v0.13

A detail - I'm using nw.js to run an express server that then runs the rest of my app. If I use Twitch.init by itself & only passing a client ID, I get console output that it connected.

When I try to pass nw.gui to it, this is where I run into issues.

var gui = require('nw.gui');
Twitch.init({
      clientId: '<CLIENTID>',
      session: status,
      nw: gui
    }, function(error, status) {
      if (error) {
          console.log(error);
      }
      if (status.authenticated) {
          console.log('SYS: User is authenticated. ' + status);
      }
});

This results in Uncaught Error: Invalid value for argument 2. Property 'toolbar': Unexpected property.

I tried removing the toolbar property from twitch-sdk/twitch.js entirely. It passes this part now, obviously because we're just skipping the problem. But then it fails on win.on('loaded'... saying on is an unknown property of win.

So... basically nw.gui is not being passed correctly to twitch-sdk. What's at fault here?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.