spiermar / burn Goto Github PK

burn :fire: is a CLI tool to convert performance profiles to hierarchical data structures that can be visualized as flame graphs

License: Apache License 2.0

Go 100.00%

burn's People

Contributors

Stargazers

Watchers

Forkers

sthagen granulate codeperfio vkarunx benburwell juju812 shen390s

burn's Issues

option to take input from pipe

load golang samples from /debug/pprof endpoints

support for v8-profiler format

use travis-ci to build and upload binaries to bintray

support for jstack format

support for golang proto format

support for selfValue

How to use with pprof

In the readme it says you can use this with pprof. We're using gperftools, and the output files can be rendered in various formats (e.g. traces) by using pprof. However I can't find documentation on

Which output format to use on pprof.
Which format to select for burn convert.

The examples seem to only concern perf.

Sample in README was broken by d3.fetch moving from callbacks to Promises

If I run the example in the README:

<head>
  <link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/d3-flamegraph.css">
</head>
<body>
  <div id="chart"></div>
  <script type="text/javascript" src="https://d3js.org/d3.v7.js"></script>
  <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/[email protected]/dist/d3-flamegraph.min.js"></script>
  <script type="text/javascript">
  var chart = flamegraph()
    .width(960);

  d3.json("data.json", function(error, data) {
    if (error) return console.warn(error);
    d3.select("#chart")
      .datum(data)
      .call(chart);
  });
  </script>
</body>

The callback isn't called, even though loading data.json succeeded with HTTP 200. This is because d3 moved from callbacks to returning a promise in d3 v5.

support for ptrace format

support for .cpuprofile format

Parsing perf_events data fails due to an empy stack in perf.out

Hi, just ran into this while trying out burn:

It seems that perf can in some cases produce empty stacks like this in perf script output:

         [... previous stack ...]
         8478b48f58948fb [unknown] ([unknown])

nginx 13444 12560.036548:     649918 cycles:ppp:

nginx 13444 12560.036810:     654301 cycles:ppp:
            7fffad2da0f9 __tcp_push_pending_frames ([kernel.kallsyms])
            7fffad2c677b tcp_push ([kernel.kallsyms])
            7fffad2ca098 tcp_sendmsg_locked ([kernel.kallsyms])
            [...]

When trying to convert this (with the latest prebuilt binary), burn fails with a panic:

user@92cdb21822ae:~$ ./burn convert --html --output=/data/flame.html out.perf
panic: Invalid format.

goroutine 1 [running]:
github.com/spiermar/burn/convert.ParsePerf(0xa476e0, 0xc42000c120, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/mspier/Workspace/go/src/github.com/spiermar/burn/convert/perf.go:104 +0xa80
github.com/spiermar/burn/cmd.glob..func1(0xa794c0, 0xc42006fd70, 0x1, 0x3)
	/Users/mspier/Workspace/go/src/github.com/spiermar/burn/cmd/convert.go:80 +0x2a6
github.com/spf13/cobra.(*Command).execute(0xa794c0, 0xc42006fcb0, 0x3, 0x3, 0xa794c0, 0xc42006fcb0)
	/Users/mspier/Workspace/go/src/github.com/spf13/cobra/command.go:653 +0x299
github.com/spf13/cobra.(*Command).ExecuteC(0xa79700, 0xc4200160b8, 0x0, 0xc42008a2d0)
	/Users/mspier/Workspace/go/src/github.com/spf13/cobra/command.go:728 +0x339
github.com/spf13/cobra.(*Command).Execute(0xa79700, 0x0, 0x0)
	/Users/mspier/Workspace/go/src/github.com/spf13/cobra/command.go:687 +0x2b
github.com/spiermar/burn/cmd.Execute()
	/Users/mspier/Workspace/go/src/github.com/spiermar/burn/cmd/root.go:79 +0x31
main.main()
	/Users/mspier/Workspace/go/src/github.com/spiermar/burn/main.go:20 +0x20