specy / genshin-music Goto Github PK

Our objective in this issue is to refactor the files where the code smell large file was identified by reactsniffer

Our objective in this issue is to refactor the files where the code smell large components was identified by reactsniffer

The project has reached a size which is big enough to need testing before updating. UI wise it's hard to test, but it should be doable to at least add tests to the lib part of the app, which takes care of the logic of the app.
In the future i'd like to add testing of stores and possibly compoenents, but lib is a good enough start for now

I try to play Do Mi Son but when I try to play it fast, it doesn't register Mi.

Currently only one app is built at a time, it would be nice to be able to build both apps at the same time and let them be in their corresponding folder in the build folder.
Example, by running yarn run buildAll, the build script will execute which will then build both sky and genshin apps into

build>sky (when building sky)
build>genshin (when building genshin)

For anyone wanting to take this issue for hacktoberfest, make sure that assets are copied while building the two different apps, as they need different static files

This would also change the build directories when building only a single app too, so when running yarn run buildSky, the build destination will be

build>sky

Configuring ESLint with Rocketseat ESLint config allows for better code standardization along with the following user settings in VSCode in the settings.json file:
"eslint.validate": ["javascript", "typescriptreact", "javascriptreact"],
"editor.codeActionsOnSave": {
  "source.fixAll.eslint": true,
  "source.organizeImports": true
},
This configuration allows auto correction and organization of imports.

Today, Genshin Impact 4.6 forward-looking live broadcast added a new Instrument, it looks like an french horn