Git Product home page Git Product logo

speckleadmin's People

Contributors

dependabot[bot] avatar didimitrie avatar htlcnn avatar mswaidan avatar paulpoinet avatar pearswj avatar radumg avatar teocomi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

speckleadmin's Issues

Viewer loading bar should be determinate & better placed

Step 0:

The viewer's progress bar is currently indeterminate, even if it is actually a determinate process (number of object request buckets left).

Flagging this up as it's rather stupid not to properly display model loading progress when we actually can (consider adding a percentage info somewhere too, as the bar itself is rather abstract).

Non-solid extrusions fail

Step 0:

Expected Behaviour

Extrusions seem to be not really working with non-solid ones. A single/curve/polyline/polycurve line is extruded in an open surface, but threejs fills it up.

Affected Projects

Does this issue propagate to other dependencies or dependants? If so, list them here!

Reproduction Steps & System Config (win, osx, web, etc.)

StreamId: B1zNJbklm @ speckle hestia

image

Streams/project Permissions misleading

Step 0:

Expected Behaviour

Write permissions for project owners displayed as default

Actual Behaviour

Whilst I am the project owner Speckle Admin shows I have read permissions only for both streams/project. Display bug?

image

Affected Projects

WS

Reproduction Steps & System Config (win, osx, web, etc.)

Proposed Solution (if any)

Archive/Delete streams

Tasks:

  • do not display in main list
  • have option to search through them or display them at one point

Sharing link doesn't include object / property filter

Step 0:

Expected Behaviour

It would be great if the sharing link would also include the property filtering and object selection. This would let you share links about a specific object or properties, or otherwise provide different "views" into a stream with different links.

I.e. https://hestia.speckle.works/#/view/<streamId>?properties.coolness_factor

Actual Behaviour

The sharing link just shares the stream ID, i.e. https://hestia.speckle.works/#/view/<streamId>

Proposed Solution (if any)

Include the query filter in the shareable link.

Change 'name' to 'layer name' in stream creation view

Step 0:

Expected Behaviour

Creating a data object via the web interface should create a named object using the input name, with its value field set to the input data.

Actual Behaviour

Creating a data object via the web interface creates a new layer with the input name, and an object without a name (it is null) and its value field set to the input data.

Affected Projects

Does this issue propagate to other dependencies or dependants? If so, list them here!

Not sure.

Reproduction Steps & System Config (win, osx, web, etc.)

Proposed Solution (if any)

Create named objects from the web interface: name becomes the object's name field, data becomes the object's value field.

SpeckleViewer right side panel tabs are hidden

Step 0:

Expected Behaviour

In the right side panel there are 4 tabs across the top of the panel which allow you to toggle between 'search for streams', 'select property...', view code, and settings. These should always be accessible

Actual Behaviour

When the page is zoomed to a certain extent, the right hand panel auto-hides and after this point, the tabs across the top of the panel are no longer visible.

Affected Projects

nah

Reproduction Steps & System Config (win, osx, web, etc.)

e.g. https://www.dropbox.com/s/py3xp9lxc9je6hv/twinner%20-%20Google%20Chrome%2021.10.2019%2013_42_36.mp4?dl=0

login form shouldn't validate password length

Actual behaviour

I've successfully created a Speckle account with the API :

{
  "email": "[email protected]",
  "password": "testing",
  "name": "Radu",
  "surname": "Gidei",
  "company": "Grimshaw",
}

but if i try to log in to Speckle server using the Admin app, it validates the password field, requiring it to be longer than 8 characters.

speckle login

Expected behaviour

I should be able to log in using my pre-existing password.
Whilst validation is expected on registration page, it shouldn't be on login page.

Some curves are dismissed by the viewer

Step 0:

Expected Behaviour

The viewer should display all the curves present in the stream.

Actual Behaviour

The viewer shows less curves than it should :(

Reproduction Steps & System Config (win, osx, web, etc.)

Check this same stream on the API side and on the viewer side:
https://hestia.speckle.works/api/streams/GMmiyTy4z/
https://hestia.speckle.works/#/view/GMmiyTy4z
@didimitrie I gave you access

Proposed Solution (if any)

¯_(ツ)_/¯

Stream Data Tabular View

Step 0:

Proposed Solution (if any)

Somewhere, potentially next to the stream data tab, have an interface that allows you to view the stream's data in a tabular form.

This should be coupled with a query building mechanism that directly pings the API, so that it can be used to create query links that people can then reuse to import data in excel.

It's an open ended question; for more reference see #32.

Non-authenticated ("incognito") direct links fail

Step 0:

Expected Behaviour

If the accessed resource is public, display it. If the resource is private, show a notification.

Actual Behaviour

Because we don't set any server endpoint in the store, the requests do not end up anywhere, resulting in an invisible fail.

Reproduction Steps & System Config (win, osx, web, etc.)

Check this link out in a incognito/different browser (where you have never authenticated on the test server before).

Proposed Solution (if any)

Two ways:

  1. Either assume the server is always at ${rootUrl}/api
  2. Or add sharing buttons everywhere that append a ?server=${server api endpoint} to the link, and always check for that query param in the router or somewhere early on in the app init lifecycle, before any requests to the api are actually sent.

(1) works if we always have the plugins served by the server. (2) works if, for instance, we want to have a centrally deployed front end application that can service multiple servers.

(2) is a potentially future valid scenario, in the case of some deployments; (1) is nicer and cleaner to implement.

¯_(ツ)_/¯

Stream data sent from Dynamo/GH not showing up in UI

Step 0:

(I've not posted an issue here before, so apologies if this is in the wrong place or anything)

Expected Behaviour

For a stream created manually in Hestia, there are four tabs across the top that let you see Overview, Sharing, Edit Data, and History. Your team members can go to the Edit Data tab and view the string/number data there in the UI.
image

Actual Behaviour

I can send and receive the data in Dynamo, but there's no Data button in the UI for another team member to go look at the data I've sent to the stream. The data can also be viewed using the API url or by adding /data to the UI URL
image

image

Affected Projects

Don't think so; it's really not a huge problem since the data is still sent. It's just a little awkward for other team members to view the data in the UI if they're unfamiliar.

Reproduction Steps & System Config (win, osx, web, etc.)

Create a stream and send string/number data to it using the Speckle Sender in Dynamo then view it in the UI frontend.

Proposed Solution (if any)

I imagine having a button for 'Data' in the menu so others can view the data even if they don't have permission to edit would be sufficient.

Socket connection not authenticated

Step 0:

In here we should be passing as well the &token=${mytoken} or however the syntax was. Do refer to actually #46 re @logan12358 's comment about sockets - the whole mechanism should be offloaded and handled centrally, as we don't need to open new ones for each connection (should have one client id per session and join/leave rooms as necessary & update store accordingly).

Default URL for signin

When accessing a speckle app served by a server (from the /plugins), there is no default url present which is weird - it should use that one by default.

Flow could be on the lines of: check if url is app.speckle.systems, if yes - no default url. if it's a different url, assume it's an app served by the server and add the root url as default.

problems sharing speckle viewer

Step 0:

Expected Behaviour

When I send someone a link to speckle viewer with a particular stream displayed (e.g. https://hestia.speckle.works/#/view/NDpZHyAWc) they should be able to open in a browser and see the building model.

Actual Behaviour

If the user has never logged into the speckle server before, they see a blank speckle viewer with no model selected.

Affected Projects

¯_(ツ)_/¯

Reproduction Steps & System Config (win, osx, web, etc.)

Open an incognito window (clearing cookies would presumably have the same effect) in chrome, go here => https://hestia.speckle.works/#/view/NDpZHyAWc

Proposed Solution (if any)

¯_(ツ)_/¯ I never noticed this in the past.. Maybe roll back whatever caused it?

Right side tool panel in viewer not wide enough for all text

Step 0:

Expected Behaviour

I should be able to read everything in the right hand tool panel in speckle viewer.

Actual Behaviour

When I open the dropdowns, especially the stream selector dropdown, the names are usually cut off due to the width of the panel. the fine print under the stream name is always cut off.

E.g.
Capture

Affected Projects

Nada, its just kinda annoying if you want to see the date something was uploaded while selecting a stream in the viewer.

Reproduction Steps & System Config (win, osx, web, etc.)

open viewer, try to select a stream to view

Proposed Solution (if any)

Create width controller or at least just format that fine print so ID is on one line and date uploaded is on another.

Viewer auto-refresh

Step 0:

Expected Behaviour

There should be an option in the viewer to automatically refresh streams, rather than the current manual-only button in ViewerLoadedStreamsCard.vue. This could be a checkbox on the card, which determines whether auto-refresh is enabled for each stream. There could also be a global checkbox to enable/disable all auto-refresh (related to #45).

Actual Behaviour

Currently, there's only a manual refresh button.

Proposed Solution (if any)

There probably ought to be something stored alongside each stream to identify whether to auto-refresh or not. The websocket handler probably belongs nearer to the store than to ViewerLoadedStreamsCard.
There might be complications to be wary of around selections and filters.

Always append server url to links

Step 0:

Context: slowly move away from server-side installed plugins to single-point of contact web-uis that can connect to one/more servers (similar to slack workspaces).

Reason:

  • easier CI-CD (do it once, rather then on a per-server basis)
  • keeps user updated with latest bug fixes
  • no need for an ui that manages plugin updates on the server

Actual Behaviour

Because of the federated nature of speckle, you can use the admin ui to connect to multiple servers (see them as slack workspaces). Consequently, when sharing a link, we need to track the server that we're drawing the data from too.

Currently, the app assumes the server lies at ${rootUrl}/api, which creates headaches when sharing things from app.speckle.systems (netlify cicd), or potentially any other ci-cd'ed instance of it.

Affected Projects

For now just this one.

Proposed Solution (if any)

Append the current server's uri to all links; always check the server url on mounted and set it.

See if we can do this automagically via the router; otherwise we'll need to figure out a different way.

This might spell a bigger architectural change for the admin interface.

Add shortcut to view all project streams

Step 0:

Expected Behaviour

  • A new "rotate" button near the project title that loads all the streams at once into the viewer;
  • also the ability to search and select a project in the stream search panel, or a new "search project" panel

Actual Behaviour

Users have to manually add all the project streams for a global view

Affected Projects

none (AFAIK)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.